Shorten if else statement using php

Question

i have a question about shorten if else statement. I am trying to make a weather application using OpenWeatherMap api. But i don't like those icons. I want to change the icons like this:

if($desc == 'clear sky'){
  $weather_icon = 'clear_sky.png';
}else
if($desc == 'few clouds'){
  $weather_icon = 'few_clouds.png';
}else
if($desc == 'scattered clouds'){
  $weather_icon = 'scattered_clouds.png';
}else
if($desc == 'broken clouds'){
  $weather_icon = 'broken_clouds.png';
}else
if($desc == ''){
  .....
}
......

So my question is how can i do this with shorten if else or do you have any idea to use different thinks?

As switch statement wouldn't be shorter but definitely easier to read — John Conde
– John Conde, Commented Apr 6, 2017 at 15:53
if you trust on the pattern you could also just replace space with '_' and add the '.png' — Jeff
– Jeff, Commented Apr 6, 2017 at 15:54
But if you've got nested statements in your if statements, use if statements — Rotimi
– Rotimi, Commented Apr 6, 2017 at 15:55

apokryfos · Accepted Answer · 2017-04-06 16:08:33Z

3

Arrays are the glue that holds the universe together (if the universe is written in PHP).

$map = [
   'clear sky' => "clear_sky.png",
   'few clouds' =>"few_clouds.png", 
   'scattered clouds' => 'scattered_clouds.png'
   'broken clouds' => 'broken_clouds.png'
];

if (isset($map[$desc])) {
   $weather_icon = $map[$desc];
}

This allows you to also map unrelated words with image names as well as multiple words to the same image.

answered Apr 6, 2017 at 16:08

apokryfos

40.9k11 gold badges85 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jonathan · Accepted Answer · 2017-04-06 16:16:45Z

3

Since your description matches what you're looking for you could do this.

if (
    in_array(
        $desc,
        array(
            'clear sky',
            'few clouds',
            'scattered clouds',
            'broken clouds'
        )
    )
) {
    $weather_icon = str_replace(' ', '_', $desc) . '.png';
}

Another option would be to use a map, they they don't always match.

$map = [
    'clear sky' => 'clear_sky.png',
    'few clouds' => 'few_clouds.png',
    'scattered clouds' => 'scattered_clouds.png',
    'broken clouds' => 'broken_clouds.png',
    'thunderstorm with light rain' => 'few_clouds.png',
];

// $api['icon'] references the original icon from the api
$weather_icon = array_key_exists($desc, $map) ? $map[$desc] : $api['icon'];

edited Apr 6, 2017 at 16:16

answered Apr 6, 2017 at 15:57

Jonathan

2,87515 silver badges23 bronze badges

2 Comments

AlwaysStudent Over a year ago

Thanks for your answer but if $desc ='thunderstorm with light rain' then if i want to use the icon few_clouds.png then what should i do with your code ?

Jonathan Over a year ago

It won't work with what I gave, I was following the example you gave which had everything matching.

Yolo · Accepted Answer · 2017-04-06 15:56:44Z

2

If your weather patterns are predictable, you can just use a one liner:

$img = str_replace ( ' ' , '_', $desc ) . '.png';

However if you have a list that you cannot just alter dynaically you can use this:

$descriptions = [
     'clear sky'=>'clear_sky',
     'few clouds'=>'few_clouds',
     'scattered clouds'=>'scattered_clouds',    
     'broken clouds'=>'broken_clouds',    
];

$defaultImg = 'some_empty';

$img = !empty($desc) ? $descriptions[$desc] : $defaultImg;
$img = $img . 'png';

answered Apr 6, 2017 at 15:56

Yolo

1,5791 gold badge11 silver badges16 bronze badges

1 Comment

AlwaysStudent Over a year ago

I like this answer. So i think you checked OpenWeatherMap other weather conditions. Your answer is best for my solution. Thank you dear yolo.

Christian Carrillo · Accepted Answer · 2017-04-06 15:59:41Z

0

<?php
$desc = "clear sky";
$weather_icon = str_replace(" ","_",$desc).".png";
echo $weather_icon;
?>

answered Apr 6, 2017 at 15:59

Christian Carrillo

4143 silver badges8 bronze badges

Comments

Peter VARGA · Accepted Answer · 2017-04-06 16:00:42Z

0

It looks like you have a some fixed notation. You could use this:

<?php
$desc = 'clear sky';
convertDescriptionToImage( $desc );

function convertDescriptionToImage( $description )
{
    $arrayCodes = ["clear sky", "few clouds"];
    if ( TRUE == in_array( $description, $arrayCodes ) )
    {
        return str_replace( " ", "_", "$description.png" );
    }

    die( "$description not found" );
}

answered Apr 6, 2017 at 16:00

Peter VARGA

5,3273 gold badges49 silver badges87 bronze badges

Collectives™ on Stack Overflow

Shorten if else statement using php

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related