Laravel only update if not null

Question

Is there a way of condensing the following code into a single update()?:

    $this->validate(request(), [
        'name' => 'required|string|max:255',
        'email' => 'required|string|email|max:255|unique:users,email,'.$id,
        'password' => 'nullable|string|min:6|confirmed',
        'timezone' => 'required|timezone',
    ]);

    $user = User::findOrFail($id);
    $user->update(request()->all());
    if (!empty(request()->input('password'))) {
        $user->update(['password' => bcrypt(request()->input('password'))]);
    }

I want to get rid of the conditional statement for updating the password because I am using a mutator to bcrypt it automatically now. Is there a method like request()->allNotNull()?

That won't solve your problem, because you still need to bcrypt() your password? Also which version of Laravel are you using? — Ivanka Todorova
– Ivanka Todorova, Commented Apr 26, 2017 at 11:07
The password is bcrypted with a mutator now....sorry should have mentioned that. — kjdion84
– kjdion84, Commented Apr 26, 2017 at 12:17

Alexey Mezenin · Accepted Answer · 2017-04-26 13:35:35Z

22

You can do this:

$user = User::where('id', $id)->update(request()->all());

Maybe you'll also want to add ->take(1).

Update

In comments you've said you want to get rid of empty fields. Use array_filter():

array_filter($request->all());

If no callback is supplied, all entries of array equal to false will be removed.

edited Apr 26, 2017 at 13:35

answered Apr 26, 2017 at 10:56

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

kjdion84 Over a year ago

I want to get rid of the conditional statement for updating the password because I am using a mutator to bcrypt it automatically now. Is there a method like request()->allNotNull()?

oseintow Over a year ago

request does not have a filter method. The request object must be converted to a collection before.

Alexey Mezenin Over a year ago

@oseintow silly me. Of course, it doesn't. Updated the answer with array_filer solution which does exactly the same job (filter() uses array_filter()). Thanks.

oseintow · Accepted Answer · 2017-04-26 13:04:04Z

3

You can try this. Password will be filtered out if password is empty.

$input = collect(request()->all())->filter()->all();

$user = User::where('id', $id)->update($input);

answered Apr 26, 2017 at 13:04

oseintow

7,4213 gold badges28 silver badges31 bronze badges

1 Comment

Alexey Mezenin Over a year ago

Or just $input = array_filter($request->all()) since al filter() does is using array_filter().

Collectives™ on Stack Overflow

Laravel only update if not null

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related