Retrieve application.properties values via @Value in SpringBoot

Question

I am trying to pull data from application.properties file in Spring Boot

application.properties

host=localhost:8080
accountNumber=1234567890

TestController.java

@RestController
public class TestController {

private Logger logger = LoggerFactory.getLogger(TestController.class);

@Autowired
private TestService testServiceImpl;

@Value("${host}")
private String host;

@RequestMapping("/test")
public String test() {
    testServiceImpl = new TestService();
    return testServiceImpl.getValue();
}

TestServiceImpl.java

@Service
public class TestServiceImpl implements TestService{

    @Value("${accountNumber}")
    public String value;

    public String getValue(){
    return value;
}

When I do a REST call to localhost:8080/test, I get a null value.

TestServiceImpl is instantiated however, @Value does not seem to work.

Am I missing anything?

SOLUTION:
All I had to do was to remove the line testServiceImpl = new TestService();
I am assuming it was doing that because new TestService() was overwriting the autowired instance of TestService

Great that you solved your own problem. You are welcome to post your answer as an answer. SO encourages people to answer your own question. stackoverflow.com/help/self-answer — Amit Phaltankar
– Amit Phaltankar, Commented Jun 1, 2017 at 4:05
Since you autowired testServiceImpl, spring container will create the bean for you and you said NO by creating instance yourself with new TestService() meddling with spring. — harshavmb
– harshavmb, Commented Jun 1, 2017 at 4:07
@harshavmb Yes you are right. That is what I found to be the problem. Thank you for validating my finding! — Jun Park
– Jun Park, Commented Jun 2, 2017 at 23:51

VNT · Accepted Answer · 2017-06-01 07:44:08Z

3

To update :

Spring's DI achieved via @Autowired annotation.It creates the object for us.

@Autowired
private TestService testServiceImpl;
.
.
.

@RequestMapping("/test")
public String test() {
    // testServiceImpl = new TestService(); // make comment this line 
    return testServiceImpl.getValue();
}

edited Jun 1, 2017 at 7:44

answered Jun 1, 2017 at 7:30

VNT

9942 gold badges8 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jun Park · Accepted Answer · 2017-06-02 23:53:55Z

0

The solution I found was very simple.

All I had to do was to remove the line testServiceImpl = new TestService();

I am assumed it was doing that because new TestService() was overwriting the autowired instance of TestService.

Thank you harshavmb for verifying my solution.

Hope this helps many new Spring-ers :)

answered Jun 2, 2017 at 23:53

Jun Park

5581 gold badge7 silver badges20 bronze badges

Collectives™ on Stack Overflow

Retrieve application.properties values via @Value in SpringBoot

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related