Arrays and Pass-By-Reference

Question

I am new to coding and need to know how to display the Max, Min, Avg, and the new normalized values of my array. I have the max min and avg working correctly as of now, but am very confused on how i would have my function display the proper new values of the array. The point is to use the function; xi'=(xi-min)/(max-min) My current code is the following:

#include <iostream>
using namespace std;

void normalizeMinMaxAvg(double data[], int size,double& min, double& max, double& avg)
{
    max = 0;
    min = 0;
    int sum = 0;
    int i;
    avg = 0;

    for (i = 0; i < size; i++) {
        sum += data[i];
        if ( max < data[i]) {
            max = data[i];
        }
        if (min > data[i]) {
            min = data[i];
        }
    }
    avg = sum/size;

    for (i = 0; i < size; i++){
        data[i] = (data[i]-min)/(max-min);
    }
}


int main() 
{
    double data[] = {-10.0,0.0,20.0,30.0,500.0};
    double min, max, avg;

    normalizeMinMaxAvg (data, 5, min, max, avg);
    cout << "min = " << min << "\n";
    cout << "max = " << max << "\n";
    cout << "avg = " << avg << "\n";
    cout << data;
    return 0;
}

Don't use a raw array, but std::array or std::vector instead. — user0042
– user0042, Commented Jul 7, 2017 at 18:51
Strong chance this is school work where those would not be allowed... yet. — Michael Dorgan
– Michael Dorgan, Commented Jul 7, 2017 at 18:51
@MichaelDorgan is correct we aren't supposed to be using those yet — Snitchell_
– Snitchell_, Commented Jul 7, 2017 at 18:53
One little gotcha above - what happens if min and max are the same? — Michael Dorgan
– Michael Dorgan, Commented Jul 7, 2017 at 18:57

Hemant Gangwar · Accepted Answer · 2017-07-07 19:00:59Z

2

Your code is correctly updating the array values. But to display the array values properly use for loop like this:

int arrSize = sizeof(data)/sizeof(data[0]);
for(int i =0; i<arrSize; ++i)
    cout << data[i]<<" ";

Alternatively, you can use the vector instead of a raw array like this:

vector<double> data ={-10.0,0.0,20.0,30.0,500.0};

And pass it by reference to your function.

edited Jul 7, 2017 at 19:00

answered Jul 7, 2017 at 18:56

Hemant Gangwar

2,29218 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user0042 Over a year ago

Why not simply for(auto val: data)?

Hemant Gangwar Over a year ago

Totally agree, but question is tagged under c++ not c++11

user0042 Over a year ago

c++11 is the current standard. So why the distinction?

Guillaume Racicot Over a year ago

@HemantGangwar I think you can assume at least c++14. If the question is tagged C++98, then give a C++98 answer.

Hemant Gangwar Over a year ago

@GuillaumeRacicot Thanks Man will keep this in mind while answering next question.

Fantastic Mr Fox · Accepted Answer · 2017-07-07 18:57:07Z

1

If you want to "print out" your array you need to iterate over each member as you have already done several times:

for (int i = 0; i < array_size; i++){
    cout << data[i] << "\n";
}

What you are doing currently:

cout << data;

Will simply print the address of the array.

answered Jul 7, 2017 at 18:57

Fantastic Mr Fox

34.5k28 gold badges105 silver badges193 bronze badges

2 Comments

user0042 Over a year ago

Why not simply for(auto val: data)?

Fantastic Mr Fox Over a year ago

@user0042 This depends on the version of c++. Either is fine.

CaptainSegFault · Accepted Answer · 2017-07-07 22:29:11Z

0

data only holds the address of the array, which, in your case, is a pointer to a double, you need iterate the array and print out each value individually.

answered Jul 7, 2017 at 22:29

CaptainSegFault

821 silver badge10 bronze badges

Collectives™ on Stack Overflow

Arrays and Pass-By-Reference

3 Answers 3

5 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related