PHPUnit not catching exception

Question

Looking for some help to write better code /tests, but seemed to have stumbled across a problem straight away - any help would be greatly appreciated.

Script:

$feed = 'App\Http\Services\Supplier\Feeds\\' . ucwords($feedName) . "Feed";

if (class_exists($feed)) {
    return new $feed($headerRowToSkip);
} else {
    throw new Exception("Invalid feed type given.");
}

Test:

 public function testBuild()
{
    SupplierFeedFactory::build('MusicMagpie', 1);
    $this->expectExceptionMessage("Invalid feed type given.");
}

Error:

There was 1 failure:

1) Tests\Feature\Account\Supplier\Feeds\SupplierFeedFactoryTest::testBuild Failed asserting that exception of type "Exception" is thrown.

The expectations must be expressed before the tested code. Otherwise, they are useless. It's like you are buying an umbrella after the rain stopped. In your case, the line that calls $this->expectExceptionMessage() doesn't run because (what else?) the tested code (SupplierFeedFactory::build()) has thrown an exception. — axiac
– axiac, Commented Jul 28, 2017 at 22:47

LeeJ · Accepted Answer · 2017-07-27 20:10:25Z

3

The PHPUnit method is literal, EXPECTexception so all you have to do is put that before the exception actually happens.

public function testBuild()
{
    $this->expectException('Exception');
    $this->expectExceptionMessage("Invalid feed type given.");
    SupplierFeedFactory::build('MusicMagpie', 1);
}

answered Jul 27, 2017 at 20:10

LeeJ

1371 silver badge12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

hakre Over a year ago

You can also use annotations for that, see as well: phpunit.de/manual/current/en/writing-tests-for-phpunit.html and other examples, like Q&A here on site: stackoverflow.com/a/39837176/367456

H Aßdøµ Over a year ago

@LeeJ It is not necessary to add $this->expectException('Exception'); to test the the exception message, there were an issue filled about that and it is now solved.

Collectives™ on Stack Overflow

PHPUnit not catching exception

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related