Refactoring nested functions with arrow functions

Question

I have trouble in refactoring the following code block into separate functions.

socketHandler = (io) => {
  io.on('connection', (socket) => {
    socket.on('doLogin', data => {
      userService.getUserByName(data.uname)
        .then((doc) =>{
          if(doc && doc.pwd===data.pwd){
            socket.emit('onLogin', {status:'SUCCESS'});
          }
        }, (error) => {
          socket.emit('onLogin', {status:'Error in the application'});
        });
    });
  });
}

app.configure(socketio(socketHandler));

I tried refactoring the above code as follows.

doLogin = data => {
  userService.getUserByName(data.uname)
    .then((doc) =>{
      if(doc && doc.pwd===data.pwd){
        socket.emit('onLogin', {status:'SUCCESS'});
      }
    }, (error) => {
      socket.emit('onLogin', {status:'Error in the application'});
    });
}

socketHandler = (io) => {
  io.on('connection', (socket) => {
    socket.on('doLogin', doLogin);
  });
}

app.configure(socketio(socketHandler));

I am getting a run-time error as socket is not defined.

How to get reference to 'socket' in the function 'doLogin'?

I also tried the following way and could not make it work.

doLogin = socket => data => {

Also tried as follows

socket.on('doLogin', doLogin.bind(socket));

Need some help in fixing this.

Thanks.

Jarek Kulikowski · Accepted Answer · 2017-07-29 17:20:59Z

2

After you broke up the functions you lost reference to socket object. You could try, in SocketHandler

socket.on('doLogin', (data) => doLogin(data, socket));

and redefine doLogin as

doLogin = (data, socket) => {

answered Jul 29, 2017 at 17:20

Jarek Kulikowski

1,3898 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Estus Flask · Accepted Answer · 2017-07-29 17:25:17Z

0

doLogin.bind(socket) won't work if doLogin is arrow function, because arrow functions cannot be bound. Instead, it should be a regular function:

function doLogin(data) {
  const socket = this;
  ...
}
...
socket.on('doLogin', doLogin.bind(socket));

answered Jul 29, 2017 at 17:25

Estus Flask

227k79 gold badges478 silver badges621 bronze badges

Collectives™ on Stack Overflow

Refactoring nested functions with arrow functions

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related