How to concat two strings in setText() in Android

Question

I am trying to do something like this:

mMovieName.setText(R.string.name + movieDetailsResponse.getTitle());

Expected Display : Name: Titanic

Actual Display : 2131165233Titanic

Can someone tell me how can I achieve expected display. I dont want to hardcode the string in TextView like this :

mMovieName.setText("Name: " + movieDetailsResponse.getTitle());

Thanks for any help

Eugen Pechanec · Accepted Answer · 2017-09-09 10:31:53Z

7

You can use Formatting strings.

Your strings.xml:

<string name="name">Name: %1$s</string>

Your Java code:

mMovieName.setText(getResources().getString(R.string.name,  movieDetailsResponse.getTitle()));

Output:

Name: Titanic

edited Sep 9, 2017 at 10:31

Eugen Pechanec

38.4k7 gold badges107 silver badges125 bronze badges

answered Sep 9, 2017 at 10:01

Niranj Patel

33.3k11 gold badges101 silver badges137 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mitesh Vanaliya · Accepted Answer · 2017-09-09 09:58:42Z

1

Hello use below code,

mMovieName.setText(getString(R.string.name) + movieDetailsResponse.getTitle());

answered Sep 9, 2017 at 9:58

Mitesh Vanaliya

2,61127 silver badges41 bronze badges

6 Comments

Sushil Over a year ago

Thanks .. this worked.. I will accept the answer in 10 minutes as the system wont allow me to it before that

pskink Over a year ago

@Sushil maybe it worked but this is not a good solution, see Niranj Patel answer instead (using Resources#getString(int id, Object... formatArgs))

Sushil Over a year ago

@pskink .. both are same solution. As I was using the function in fragment, I didnt need to explicitly call getResources

pskink Over a year ago

@Sushil no they are not, if you need a fragment then simply use Fragment#getString(int resId, Object... formatArgs)

Eugen Pechanec Over a year ago

@Sushil It's not the same. One uses formatting strings (good), one uses concatenation, which is no better than hardcoding (bad).

|

Daniel Puiu · Accepted Answer · 2018-09-30 16:09:10Z

0

You need to replace R.string.name with getResources().getString(R.string.name) because R.string.name is not a string but an Id of this string.

mMovieName.setText(getResources().getString(R.string.name) + movieDetailsResponse.getTitle());

edited Sep 30, 2018 at 16:09

Daniel Puiu

9616 gold badges21 silver badges29 bronze badges

answered Sep 30, 2018 at 11:37

Bansi Pipaliya

11 bronze badge

Comments

joao86 · Accepted Answer · 2017-09-09 09:58:16Z

-1

You should do

mMovieName.setText(getResources().getString(R.string.name) + movieDetailsResponse.getTitle());

answered Sep 9, 2017 at 9:58

joao86

2,0761 gold badge21 silver badges23 bronze badges

5 Comments

Eugen Pechanec Over a year ago

You should not. What if in another language the movie title goes first?

joao86 Over a year ago

@EugenPechanec he asked why the string was being returned as an int and I answered his question. Also he never asked or said that he might want to use another language. And finally, that is not relevant since in the example that I said Name: will always appear first.

Eugen Pechanec Over a year ago

he asked [...] and I answered his question. I must disagree, you posted some code without an explanation. You also ignored the second part of the question I dont want to hardcode the string. Concatenating two strings in Java is still a form of hardcoding (the order of strings is defined at use site). Formatting strings (the accepted answer) is better option. /// I like to think the community is here to help askers grow, in this case help OP become better Android developer by learning best practices.

Eugen Pechanec Over a year ago

Your answer is also redundant as two other people came up with the exact same thing. Always provide extra value.

joao86 Over a year ago

Your answer is also redundant as two other people came up with the exact same thing. When I answered the question, there was no other answer at that time. I agree that the answered selected is better but I don't agree that concatenating two strings is a form of hardcoding. For me that is a little farfetched.

Collectives™ on Stack Overflow

How to concat two strings in setText() in Android

4 Answers 4

Comments

6 Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

6 Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related