Python - Passing functions to other functions

Question

I'm having problems passing crapsRoll() to gameCraps(). When I define gameCraps() I get the error:

Redefining name 'crapsRoll' from outer scope.

And on the print statement I get an error that says

crapsRoll has no value.

import random 

#===========================crapsRoll()===============================
def crapsRoll():
  roll = random.randint(2,12)
  return(roll)

#===========================gameCraps()===============================
def gameCraps(crapsRoll):
  crapsRoll = crapsRoll
  if (crapsRoll == 7 or crapsRoll == 11):
    gameState = 1
  elif (crapsRoll == 2 or crapsRoll == 3 or crapsRoll == 12):
    gameState = 2
  else:
    gameState = 3
  return(gameState)

print(gameCraps())

Do you like crap so much you named 2 functions after it?

cs95
– cs95

2017-09-18 07:00:16 +00:00
Commented Sep 18, 2017 at 7:00 — cs95
– cs95, Commented Sep 18, 2017 at 7:00
@cᴏʟᴅsᴘᴇᴇᴅ crapS <-- with an 's' ?

Jean-François Corbett
– Jean-François Corbett

2017-09-18 07:10:57 +00:00
Commented Sep 18, 2017 at 7:10 — Jean-François Corbett
– Jean-François Corbett, Commented Sep 18, 2017 at 7:10

JJAACCEeEKK · Accepted Answer · 2017-09-18 07:03:46Z

2

You don't need to pass it as a argument. Just call it from another function:

def gameCraps():
  crapsRoll = crapsRoll()
  if (crapsRoll == 7 or crapsRoll == 11):
    gameState = 1
  elif (crapsRoll == 2 or crapsRoll == 3 or crapsRoll == 12):
    gameState = 2
  else:
    gameState = 3
  return(gameState)

answered Sep 18, 2017 at 7:03

JJAACCEeEKK

1941 silver badge12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

L Selter Over a year ago

This overwrites the function name with the local variable, probably not a good idea

L Selter Over a year ago

also it doesnt answer the users question, as it doesnt pass the function as an argument.

jhoepken · Accepted Answer · 2017-09-18 07:08:20Z

1

If you insist on keeping this structure, this will work:

import random 

#===========================crapsRoll()===============================
def crapsRoll():
  roll = random.randint(2,12)
  return(roll)

#===========================gameCraps()===============================
def gameCraps(crapsRoll):
  crapsRoll = crapsRoll
  if (crapsRoll == 7 or crapsRoll == 11):
    gameState = 1
  elif (crapsRoll == 2 or crapsRoll == 3 or crapsRoll == 12):
    gameState = 2
  else:
    gameState = 3
  return(gameState)

print(gameCraps(crapsRoll()))

You either have to pass the return value of crapsRoll() to gameCraps(<insert int>) or call crapsRoll() from within gameCraps(), as all functions are registered in the same namespace. I don't know the structure of your code, but I would rather refactor it, than creating such a trainwreck. This is not ment in a bad manner :).

edited Sep 18, 2017 at 7:08

answered Sep 18, 2017 at 7:05

jhoepken

1,8663 gold badges17 silver badges24 bronze badges

3 Comments

Nimish Bansal Over a year ago

we can definitely pass functions in python as an argument

jhoepken Over a year ago

Updated the answer accordingly. Thanks!

L Selter Over a year ago

this doesnt answer the users question, as it doesnt pass the function as an argument, just the result

Sanket · Accepted Answer · 2017-09-18 07:10:44Z

0

#===========================gameCraps()===============================
def gameCraps(crapsRoll):
  print crapsRoll
  if (crapsRoll == 7 or crapsRoll == 11):
    gameState = 1
  elif (crapsRoll == 2 or crapsRoll == 3 or crapsRoll == 12):
    gameState = 2
  else:
    gameState = 3
  return(gameState)

print(gameCraps(crapsRoll()))

This can be done in multiple ways, but calling function just one time will be feasible

edited Sep 18, 2017 at 7:10

answered Sep 18, 2017 at 7:04

Sanket

7451 gold badge7 silver badges23 bronze badges

Comments

L Selter · Accepted Answer · 2017-09-18 07:24:50Z

You are trying to check whether the function has a value of a number, which it doesnt, you need to call the function to get the result.

To summarize from what I believe are two nearly complete answers:

import random 

#===========================crapsRoll()===============================
def crapsRoll():
  roll = random.randint(2,12)
  return(roll)

#===========================gameCraps()===============================
def gameCraps(rollFunction):
  crapsRollResult = rollFunction()
  if (crapsRollResult  == 7 or crapsRollResult  == 11):
    gameState = 1
  elif (crapsRollResult  == 2 or crapsRollResult  == 3 or crapsRollResult  == 12):
    gameState = 2
  else:
    gameState = 3
  return(gameState)

print(gameCraps(crapsRoll))

this doesnt confuse the roll function with the result from the roll and it doesnt re roll for each condition check.

Collectives™ on Stack Overflow

Python - Passing functions to other functions

4 Answers 4

2 Comments

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related