php not able to get array value

Question

I have this problem where I can't get the value from the array in the for loop but I can access it in the while loop.

I can't seem to find a answer online, so help would be much appreciated.

while ($pos = strpos($logTxt, $char, $pos)) 
{
   $t++;
   $pos += strlen($char);
   $positions[$t] = $pos;
}

for($i = 0; $i < sizeof($positions); $i++)
{
   $beginLine = $lastEndLine; 
   $endLine = $positions[2];
   $textToEcho = substr($logTxt,$beginLine,$endLine);
   $lastEndLine = $endLine;
}

Is it always $positions[2] that you need in the for loop? As it stands I don't see a reason for the for loop at all — GrumpyCrouton
– GrumpyCrouton, Commented Sep 20, 2017 at 19:30

GrumpyCrouton · Accepted Answer · 2017-09-20 19:36:10Z

1

I think that this could be pretty easily fixed by using a foreach loop instead of a for loop, because it is an array.

foreach($positions as $position) {
    $beginLine = $lastEndLine; 
    $endLine = $position;
    $textToEcho = substr($logTxt,$beginLine,$endLine);
    $lastEndLine = $endLine;
}

If you want to use a for loop still, I believe your problem is you are only referencing the 3rd position of the array (Key 2, as arrays start at 0), not what the loop is pointing to. You could fix it by doing this

for($i = 0; $i < sizeof($positions); $i++)
{
    $beginLine = $lastEndLine; 
    $endLine = $positions[$i];
    $textToEcho = substr($logTxt,$beginLine,$endLine);
    $lastEndLine = $endLine;

}

edited Sep 20, 2017 at 19:36

answered Sep 20, 2017 at 19:32

GrumpyCrouton

8,6367 gold badges37 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

vladkras Over a year ago

$endLine = $position; plus $lastEndLine = $endLine;?

GrumpyCrouton Over a year ago

@vladkras That is a discrepancy that exists in the original code, I don't know the intentions.

Bastien Olivier Dijkstra Over a year ago

Thank you, I was so fixed on that the while loop had to work that I got stuck.

Justinas · Accepted Answer · 2017-09-20 19:32:34Z

0

Your $endLine always has third element from array, because of $positions[2]. Try changing it to $positions[$i]

answered Sep 20, 2017 at 19:32

Justinas

43.9k5 gold badges72 silver badges108 bronze badges

Comments

vladkras · Accepted Answer · 2017-09-20 20:12:25Z

0

You base problem is using constant index in $positions[2]. But your 1st line in for loop $beginLine = $lastEndLine; will always fail because $lastEndLine is not defined yet. You can use smth like

                              // beginLine      // endLine
$textToEcho = substr($logTxt, $positions[$i-1], $positions[$i]);

of course you need $positions[-1] set to 0 before your first loop or smth like this (it's not clear what's happening before)

UPD I've tried your code and concluded

it will not work at all if $char is the first occurence in $logTxt
it does the nearly the same as explode() function

edited Sep 20, 2017 at 20:12

answered Sep 20, 2017 at 20:03

vladkras

17.2k4 gold badges50 silver badges55 bronze badges

2 Comments

Bastien Olivier Dijkstra Over a year ago

Yes I was aware of this problem, but I needed to be able to get the variable first so i could go further.

vladkras Over a year ago

So set $beginLine to zero at first loop, not to undefined variable

Collectives™ on Stack Overflow

php not able to get array value

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related