Codeigniter variables from constructor are undefined

Question

I'm using CI's Auth Tank library to query records for certain users.

The variable $user_id = tank_auth->get_user_id(); grabs the user id from the session. I want to pull records where user_id = $user_id.

From what I understood, constructors can load variables each time a class is initiated. Sort of like global variables. So I figured I'll set my $user_id in a model constructor so I can use it for multiple functions within the model class.

class My_model extends Model {

    function My_model() 
    {
        parent::Model();
        $user_id = $this->tank_auth->get_user_id();     
    }

        function posts_read() //gets db records for the logged in user
    {       
        $this->db->where('user_id', $user_id);
        $query = $this->db->get('posts');
        return $query->result();
    }
}

Next, I'm loading the model, creating an array in my controller, and sending the data to my view where I have a foreach loop.

When testing I get

Message: Undefined variable: user_id

in my model. It works however if I define the $user_id variable in my posts_read function, but I don't want to define it in every function that needs it.

What am I doing wrong here?

Gruber · Accepted Answer · 2021-09-01 06:39:25Z

11

Variable scope problem. You should create class-level variables so that it is available in other functions as well like this:

class My_model extends Model {
    private $user_id = null;

    function My_model() 
    {
        parent::Model();
        $this->user_id = $this->tank_auth->get_user_id();     
    }

    // gets db records for the logged in user
    function posts_read()   
    {       
        $this->db->where('user_id', $this->user_id);
        $query = $this->db->get('posts');
        return $query->result();
    }
}

Notice the addition of $user_id after class declaration which is later used with $this->user_id :)

edited Sep 1, 2021 at 6:39

Gruber

2,3385 gold badges32 silver badges52 bronze badges

answered Jan 9, 2011 at 18:28

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

CyberJunkie Over a year ago

Thanks! It seems to work without a class-level var as well. Is that alright?

vicky Over a year ago

function My_model is not a constructor. Check this stackoverflow.com/questions/13555822/…

DrColossos · Accepted Answer · 2011-01-09 18:26:49Z

6

Pull it into global scope

class My_model extends Model {

    $user_id = 0;

    function My_model() {
        parent::Model();
        $this->user_id = $this->tank_auth->get_user_id();     
    }

    function posts_read() //gets db records for the logged in user {       
        $this->db->where('user_id', $this->user_id);
        $query = $this->db->get('posts');
        return $query->result();
    }
}

answered Jan 9, 2011 at 18:26

DrColossos

13.1k3 gold badges49 silver badges68 bronze badges

1 Comment

DrColossos Over a year ago

@CyberJunkie The same as did Safraz with NULL. I initialised it with a real value since no user will have 0 as his id. Both NULL and 0 are fine IMO

Collectives™ on Stack Overflow

Codeigniter variables from constructor are undefined

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related