CodeIgniter : Undefined variable get from __construct()

Question

I'm working on a project. Here's my code :

Controller

public function __construct(){
  parent::__construct();
  
  $x = $this->input->get('x');
  $this->model->val = $this->model->checkval($x);
}

public function save(){
  // some code to input to database
  echo $this->model->val;
}

Model

public function checkval($x){
  switch($x){
    case 1 : $y = 10; break;
    case 2 : $y = 20; break;
    case 3 : $y = 30; break;
  }
  return $y;
}

(That's the simple version)

Message : Undefined variable: y

Filename : models/Test_model.php

I want to access save(), and it will process the $this->model->val ($this->model->val has been declared as public $val in Model). $this->model->val is get from $this->model->checkval($x) where $x is get from GET method. But, it shows this error. What did I do wrong?

try $_REQUEST['x'] in constructor

Devsi Odedra
– Devsi Odedra

2019-06-01 11:58:18 +00:00
Commented Jun 1, 2019 at 11:58 — Devsi Odedra
– Devsi Odedra, Commented Jun 1, 2019 at 11:58

John Conde · Accepted Answer · 2019-06-01 11:56:30Z

2

If $x is not equal to 1, 2, or 3 it is never defined. To prevent this you need a default value for $y which then can be changed if $x matches one of those values:

public function checkval($x){
  $y = 0; // This can be false or whatever other value makes sense for your business logic
  switch($x){
    case 1 : $y = 10; break;
    case 2 : $y = 20; break;
    case 3 : $y = 30; break;
  }
  return $y;
}

answered Jun 1, 2019 at 11:56

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

F.Joodaki Over a year ago

Please correct controller to correct it: parent::__construct();

Collectives™ on Stack Overflow

CodeIgniter : Undefined variable get from __construct()

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related