Error in onclick function

Question

I added onclick event to below query, but it doesn't work. I used ruby on rails . Help me out to get a solution. Thank you...

for (var j = 0; j < 3; j++){
   $('#sub').append("<div class='col-md-12' '><img src='picture.jpg' class='subPic' style='cursor:pointer;' onclick='sayhello()'></div>");
}
function sayhello(){
  alert("hello");
}

your updated code is working.. what is the error you are encountering? — Shadow Fiend
– Shadow Fiend, Commented Oct 10, 2017 at 6:42
where you able to append the img? if not then maybe result["prd_image"].length; is the problem.. — Shadow Fiend
– Shadow Fiend, Commented Oct 10, 2017 at 6:46
I changed it. but error is still the same . I coded this on ruby on rails . is it the problem? — Chamith Niroshana
– Chamith Niroshana, Commented Oct 10, 2017 at 7:01

lumio · Accepted Answer · 2017-10-10 07:40:19Z

1

Your function needs a name. I chose the name "callAlert" here.

for (var j = 0; j < result["prd_image"].length; j++){
   $('#sub').append("<div class='col-md-12' '><img src='picture.jpg' class='subPic' style='cursor:pointer;' onclick='callAlert()'></div>");
}
function callAlert(){
  alert("hello");
}

edited Oct 10, 2017 at 7:40

lumio

7,6054 gold badges42 silver badges60 bronze badges

answered Oct 10, 2017 at 6:38

Benjamin Schüller

2,2191 gold badge21 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Benjamin Schüller Over a year ago

Do you have any output on browser console?

Chamith Niroshana Over a year ago

Yeah " Uncaught ReferenceError: sayhello is not defined at HTMLImageElement.onclick (VM23994 89:1)"

Chamith Niroshana Over a year ago

error is i defined that sayhello function inside of wrong function thanks for your cooperation

Carsten Løvbo Andersen · Accepted Answer · 2017-10-10 06:39:57Z

1

You need to assign a name to the function, like function sayhello() and then call it like onclick='sayhello()'

for (var j = 0; j < 2; j++) {
  $('#sub').append("<div class='col-md-12' '><img src='picture.jpg' class='subPic' style='cursor:pointer;' onclick='sayhello()' alt='awda'></div>");
}

function sayhello() {
  alert("hello");
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div id="sub"></div>

answered Oct 10, 2017 at 6:39

Carsten Løvbo Andersen

27.1k10 gold badges53 silver badges80 bronze badges

3 Comments

Chamith Niroshana Over a year ago

these changes are worked in here. but i in my code errors are still the same. I'm working my project on ruby on rails .

Chamith Niroshana Over a year ago

VM23994 89:1 Uncaught ReferenceError: sayhello is not defined at HTMLImageElement.onclick (VM23994 89:1) error is appeared in browser console

Chamith Niroshana Over a year ago

error is i defined that sayhello function inside of wrong function thanks for your cooperation

Collectives™ on Stack Overflow

Error in onclick function

2 Answers 2

3 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related