Why my linked list is displaying garbage values

Question

My doubly Linked list in C is displaying garbage value instead of value that I have entered, I have run this code on Turbo C++. the code compiled correctly with 0 errors and 0 warnings, but still it is displaying some garbage values. I have included the libraries (stdio.h,conio.h,stdlib.h,malloc.h) here is the code :

struct dlist
{
  int data;
  struct dlist *next;
  struct dlist *prev;
};

struct dlist *head, *end;

void create_dlist()
{
  char k='y';
  struct dlist *new_node;
  while(k=='y'||k=='Y') {
    if(head==NULL) {
      new_node=(struct dlist *)malloc(sizeof(struct dlist));
      printf("Enter the integer value -> ");
      new_node->data=0;
      new_node->next=NULL;
      new_node->prev=NULL;
      scanf("%d",&new_node->data);
      head=new_node;
      end=new_node;
    } else {
      new_node=(struct dlist *)malloc(sizeof(struct dlist));
      printf("Enter the integer value -> ");
      new_node->data=0;
      new_node->next=NULL;
      new_node->prev=end;
      scanf("%d",&new_node->data);
      end->next=new_node;
      end=new_node;
    }
    printf("Do you want to continue (y/n) ; ");
    scanf(" %c",&k);
  }
}

void display()
{
  struct dlist *pointer;
  pointer=head;
  if(pointer!=NULL) {
    while(pointer->next!=NULL) {
      printf("%d\t",&pointer->data);
      pointer=pointer->next;
    }
  } else {
    printf("list is empty");
  }
}

int main()
{
  clrscr();
  head=NULL;
  end=NULL;
  create_dlist();
  display();
  getch();
  return 0;
}

A coded solution will be a great help

For one thing, it looks like display is not showing the last element of the list. For instance, if the list has exactly one element, the while loop will exit immediately before doing anything. — Tom Karzes
– Tom Karzes, Commented Oct 17, 2017 at 18:56
And printf("%d\t",&pointer->data); --> printf("%d\t", pointer->data); — BLUEPIXY
– BLUEPIXY, Commented Oct 17, 2017 at 20:55

J...S · Accepted Answer · 2017-10-18 06:25:56Z

2

Whole problem is in display(). First you print address and not value of data. Also, you are not printing last element. I made some changes. Ask me if you need any explanations.

void display()
{
    struct dlist *pointer;
    pointer=head;
    if(pointer!=NULL)
    {
        while(pointer!=NULL)
        {
            printf("%d\t",pointer->data);
            pointer=pointer->next;
        }
    }
    else
    {
        printf("list is empty");
    }
}

edited Oct 18, 2017 at 6:25

J...S

5,2772 gold badges25 silver badges39 bronze badges

answered Oct 17, 2017 at 19:03

marko

777 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why my linked list is displaying garbage values

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related