Linked List Creation - Garbage Output?

Question

Can't seem to work out why I'm getting garbage output from this Linked List structure when I print the contents.

My goal is to add anything to the list, some string, char by char, an it should print it out in reverse. The reason Im using the extra Struct for Head + Tail is so that I can then print out the the order lines were entered in reverse as well.

typedef struct List {
 char c;
 struct List *next;
}List;

typedef struct  {
 List *head;
 List *tail;
}FullList;

List* InsertList(int hd, List* t1) {
 List *t = (List*)calloc(1,sizeof(List));
 t->c = hd; 
 t->next = t1;
return t;
}


FullList addToStart(FullList c, char element) {
 if (c.head == NULL) {
    c.head = c.tail = InsertList(element, NULL);
 }else {
    c.head = InsertList(element, c.head);
 }
return c;
}

int main(void) {
 FullList InOrder;
 FullList Reverse;
 InOrder.head = NULL;
 Reverse.head = NULL;
 char c;

  while ((c = getchar() != '.')) {
    InOrder = addToStart(InOrder, c);
 }
  while (InOrder.head->next != NULL) {
    printf("%c", (InOrder.head->c));
    InOrder.head = InOrder.head->next;

}     
return 0;           
}

codaddict · Accepted Answer · 2012-06-08 12:30:52Z

5

The problem is here:

while ((c = getchar() != '.'))

it should be:

while ((c = getchar()) != '.')

because != has higher precedence than =.

What you are doing in while ((c = getchar() != '.')) is:

You read a character by calling getchar.
Compare if the character read is period or not.
Assign the result of comparison to c, so your c will be either 0 or 1. And when you print the character with value 1 you see that weird looking char.

Also note that the return type of getchar is int, so you need to declare c as int.

Also

while (InOrder.head->next != NULL)

should be:

while (InOrder.head != NULL)

else you prematurely terminate the loop without processing the last node.

edited Jun 8, 2012 at 12:30

user785541

answered Nov 26, 2011 at 12:07

codaddict

457k83 gold badges502 silver badges537 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

PnP Over a year ago

Cheers, although it seems to skip off the first letter of what I input for example: Hello, prints olle but no H.

PnP Over a year ago

Still cant seem to get that last char printing for some reason, it just skips it entirely.

Seth Carnegie Over a year ago

@user1048116 change while (InOrder.head->next != NULL) to while (InOrder.head != NULL)

PnP Over a year ago

Fixed :) Cheers for all the help!

PnP Over a year ago

hehe Seth, liturally fixed that as you posted that!

Collectives™ on Stack Overflow

Linked List Creation - Garbage Output?

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related