Unable to check empty string in if condition using ionic2

Question

I'm Working on search form were i need to check whether city is empty or not. If it is empty then assign Bangalore to it other show the selected city. Here is my If condition

if(this.locations[0].city!="")
{
   var Dynamic = this.locations[0].city;
}
else
{
   Dynamic = "Bangalore";
}

But getting

Runtime Error. cannot read property '0' of undefined.

I am new to Ionic 2.

Prithivi Raj · Accepted Answer · 2017-11-02 14:20:08Z

1

modify the IF condition like the below

 if(this.location!=undefined && this.location.length!=0 && this.locations[0].city!="")
    {
       var Dynamic = this.locations[0].city;
    }
    else
    {
       Dynamic = "Bangalore";
    }

answered Nov 2, 2017 at 14:20

Prithivi Raj

2,7361 gold badge22 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Philip Brack · Accepted Answer · 2017-11-03 01:43:41Z

1

I might do this

var Dynamic = "Bangalore";
' first to are verifying they are defined
if(this.locations && this.locations[0] && this.locations[0].city && this.locations[0].city.length > 0)
{
  Dynamic = this.locations[0].city;
}

edited Nov 3, 2017 at 1:43

answered Nov 2, 2017 at 15:11

Philip Brack

1,32815 silver badges26 bronze badges

1 Comment

Ari Over a year ago

I think this will fail if this.locations[0] is undefined.

Ari · Accepted Answer · 2017-11-02 23:49:48Z

0

I suggest you create a function called checkNested for checking the validity of a nested object and use it throughout your app. You can put that in a service.

Also, I think you should define Dynamic outside of the if statement for scoping reasons.

var Dynamic = "Bangalore";
if(this.locations &&  // Checking if this.locations is valid before indexing it
   this.checkNested(this.locations[0], "city") && 
   this.locations[0].city !="" ){
   Dynamic = this.locations[0].city;
}

checkNested function is defined here.

answered Nov 2, 2017 at 23:49

Ari

7,63411 gold badges43 silver badges77 bronze badges

Collectives™ on Stack Overflow

Unable to check empty string in if condition using ionic2

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related