problem when comparing string in typescript

Question

I have this code:

switch (cpf) {
      case this.aluno.cpf.length == 0:
        this.cpfVazio = true;
      break;

      case this.aluno.cpf.length != 14:
        this.cpfVazio = true;
      break;
      default:
        this.cpfVazio = false;
      break;
    }

this.aluno.cpf is a string. And it is not comparing always going to default. Does anyone know what is wrong?

Here is the HTML code and the class Aluno:

<ion-item>
        <ion-label position="floating">CPF*</ion-label>
        <ion-input type="text" [(ngModel)]="aluno.cpf" [brmasker]="{mask: '000.000.000-00', len:14, type:'num'}" (ionBlur)="validaCpf(aluno.cpf)" (ionChange)="validaCpf(aluno.cpf)" name="cpf" required></ion-input>
      </ion-item>
      <small class="mensagem-erro" *ngIf="cpfVazio" name="cpf">Este campo é obrigatório!</small><br>

export class Aluno {
    inscricao = "";
    dataInscricao = "";
    nome = "";
    dataNascimento = "";
    cpf = "";
    endereco = "";
    cidade = "";
    bairro = "";
    cep = "";
    contatos = "";
    email = "";
    facebook = "";
    igreja = "";
    soube = "";
    proposito = "";
    historico = "";
}

What are you actually trying to validate, because maybe minLength and maxLength of 14 would be easier? — Sam
– Sam, Commented Jan 28, 2020 at 16:58

Iulian Cucoanis · Accepted Answer · 2020-01-28 16:53:25Z

1

For your use case it's better to use an if/else statement. It's way cleaner and easy to reason about.

On the other hand, your switch statement is a bit weird. If you want to use cpf's length then you have to include it in the switch statement like switch (cpf.length) { ... } and then in your case use something like case 0: do something. It will also work with an expression but it's not a pretty solution. Use if/else instead.

answered Jan 28, 2020 at 16:53

Iulian Cucoanis

2053 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tiedmud Over a year ago

Thx it didn't work with an expression but it worked when I put (cpf.length) and case 0: it worked! dont know why it didnt work the other way!

Thomas Ruble · Accepted Answer · 2020-01-28 17:00:17Z

1

Try this:

if (this.aluno.cpf.length !== 14) {
  this.cpfVazio = true;
} else {
  this.cpfVazio = false;
}

answered Jan 28, 2020 at 17:00

Thomas Ruble

9622 gold badges8 silver badges19 bronze badges

Comments

tiedmud · Accepted Answer · 2020-01-28 18:15:01Z

0

Thx all! It didn't work with an expression but it worked when I put (cpf.length) and case 0: it worked! dont know why it didnt work the other way!

Maybe if I put like this: ´´´ case cpf.length == 0: ´´´ It would work, because I wasnt using the cpf variable inside the switch!

answered Jan 28, 2020 at 18:15

tiedmud

971 silver badge7 bronze badges

Collectives™ on Stack Overflow

problem when comparing string in typescript

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related