Django Form save - circular dependency

Question

I have 2 models Account and User. An Account can have multiple users.

When the first User(Owner) is created at the same time the Account will be created.

Because User have a ForeignKey to Account, I need first to create the Account, and after the User.

But Account had a field created_by which is request.user. So is a circular problem.

I think I need to create first the Account and created_by to be a superuser(first) and than create the User, and update the Account with the new user.

class Account(MetaData):
    name = models.CharField(max_length=255)
created_by = models.ForeignKey(settings.AUTH_USER_MODEL, blank=True,
                                   related_name='%(app_label)s_%(class)s_created_by', on_delete=models.CASCADE)

class User(AbstractBaseUser):
    account = models.ForeignKey(settings.AUTH_USER_MODEL, blank=True, null=True, related_name='owner')

How can I do that ?

I need this only first time, for the first user, because after that for the other users the Account will exist.

When I'm saying first user, I'm not referring to staff users (as superusers), but normal users for which an account is mandatory thru a register form.

blank=True is just for staff members.

just a note, not a solution: in the code above, account field on User model is pointing to User (not Account) assuming AUTH_USER_MODEL is User. — dirkgroten
– dirkgroten, Commented Dec 7, 2017 at 11:56

bruno desthuilliers · Accepted Answer · 2017-12-07 13:12:43Z

2

Your User model's account field allows nulls, so nothing prevents you from first creating the user without an account, then creating the account with this user, and finally updating the user with the account:

 with transaction.atomic():
     user = User.objects.create(account=None, ...)
     account = Account.objects.create("test", created_by=user)
     user.account = account
     user.save(update_fields=["account"])

answered Dec 7, 2017 at 13:12

bruno desthuilliers

78.3k6 gold badges103 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

bruno desthuilliers · Accepted Answer · 2017-12-07 13:06:20Z

0

Since it's only a problem for the first user, you might want to override the method create_superuser of the manager to add the account. Also, since you've defined the ForeignKeys with null=True, it should not be a problem to first create a superuser (using super().create_superuser()) and then create the account and attach it to the superuser.

When deploying your site the first time, you'll have to manually run the ./manage.py createsuperuser command.

edited Dec 7, 2017 at 13:06

bruno desthuilliers

78.3k6 gold badges103 silver badges129 bronze badges

answered Dec 7, 2017 at 12:01

dirkgroten

20.8k2 gold badges32 silver badges46 bronze badges

2 Comments

user3541631 Over a year ago

when I'm saying first user, I'm not referring to staff users (as superusers), but normal users for which an account is mandatory

dirkgroten Over a year ago

ah ok, that wasn't clear. Then the other answer fits the problem.

Collectives™ on Stack Overflow

Django Form save - circular dependency

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related