Bubble Sorting Algorithm in C++

Question

I'm trying to implement the bubble sorting algorithm to an array of integers, the function which sorts the array takes an array as a parameter and suppose to return the sorted array.

Here is the code:

#include <iostream>

using namespace std;
int* BubbleSort(int data[]){

for(int i=0; i<sizeof(data)/sizeof(data[0])-1; i++){
    for(int j=0; j<sizeof(data)/sizeof(data[0])-1-i; j++){
         if(data[j+1]>data[j]){
            int temp = data[j+1];
            data[j+1]=data[j];
            data[j]=temp;
        }
    }
}
return data;
}

int main()
{
    int data[]={8,4,9,7,6,5,13,11,10};
    int *a=BubbleSort(data);
    cout<<"{";
    for(int i=0; i<sizeof(data)/sizeof(data[0]); i++){
        cout<<a[i];
        if(i==sizeof(data)/sizeof(data[0])-1){
        cout<<"}"<<endl;
        }else{
        cout<<",";
        }
    }

   return 0;
}

The output I'm getting: {8,4,9,7,6,5,13,11,10}

Turn your warnings on. I got warning: sizeof on array function parameter will return size of 'int *' instead of 'int []' [-Wsizeof-array-argument]. — HolyBlackCat
– HolyBlackCat, Commented Mar 3, 2018 at 18:57
You need to pass in the length of the array as a parameter to the function. Or do the "modern" thing and use a container like std::array or std::vector — UnholySheep
– UnholySheep, Commented Mar 3, 2018 at 18:59
Handy extra reading on why this happened: What is array decaying? — user4581301
– user4581301, Commented Mar 3, 2018 at 19:21
sizeof() returns the size of something in bytes, so it should never be used to get the size of an array. Also, when an array is passed to a function, it's not copied. So you don't need to return the sorted array. How did you learn to do stuff like return the pointer? — user9254539
– user9254539, Commented Mar 3, 2018 at 19:34

Raindrop7 · Accepted Answer · 2018-03-03 19:13:44Z

5

You must pass in the size of the array because an array it decays to the pointer to its first element (element 0).

void BubbleSort(int data[], int size){

    for(int i(0); i != size; ++i){
         for(int j(i + 1); j != size; ++j){
             if(data[i] > data[j]){
                  int temp = data[i];
                  data[i] = data[j];
                  data[j] = temp;
          }
     }    
}

answered Mar 3, 2018 at 19:13

Raindrop7

3,9113 gold badges19 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mrasadatik · Accepted Answer · 2022-08-26 15:46:46Z

Maybe too late, but maybe in the future it will be useful,

Try to use this code


...

/**
* Sort array of integers with Bubble Sort Algorithm
*
* @param arr   Array, which we should sort using this function
* @param arrSZ The size of the array
* @param order In which order array should be sort
*
* @return Sorted array of integers
*/
void bubbleSortInt(double arr[], int arrSz, string order = "ascending")
{
    for (int i = 0; i < arrSz; ++i)
    {
        for (int j = 0; j < (arrSz - i - 1); ++j)
        {
            // Swapping process
            if ((order == "descending") ? arr[j] < arr[j + 1] : arr[j] > arr[j + 1])
            {
                swap(arr[j], arr[j + 1]);
            }
        }
    }
    return; // Optional because it's a void function
}// end bubbleSortInt

...

Then use it in your main function like below,


...

double integers[array_size];
const int array_size = 10;
string order = "ascending";
bubbleSortInt(integers, array_size, order)
for (int i = 0; i < array_size; ++i)
{
    cout << integers[i] << "\t";
}

...

Have a detailed look at the bubble sort algorithm -> https://github.com/teamroyalcoder/algorithms#bubble-sort-algorithm

This is a GitHub repo where you will find a bunch of algorithms with full details and source code written in c++ https://github.com/teamroyalcoder/algorithms

Collectives™ on Stack Overflow

Bubble Sorting Algorithm in C++

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related