How do you create an Array for every Object and add it to a List (c#)

Question

What I'm trying to do is create multiple Objects of the same class, each with their own set of values (e.g. a name, an address and a personal number) saved in an array, and later add it to a list of employees but when I try to create an Object the name and address stay as null. This is what I have so far:

 abstract class Person
{
    static public string _name;
    static public string _adresse; 

}

class Student : Person
{
    #region fields

    public string _personalnumber = Fakultät.generate_personalnr();

    #endregion

    //initiating the array witht the Infos about the Student
    public string[] StudentenA = new string[3] { Person._name, Person._address, personalnumber };

    #region const
    public Studenten (string name, string address)
    {
        Person._name = name;
        Person._address = address;

    }
    #endregion

Thanks in advance for your help. Bearowl

edit 1: changed the variables to all English (all German in original Project)

What name and address? In the array? In the constructor method? Have you debugged it? — Aryan Firouzian
– Aryan Firouzian, Commented May 31, 2018 at 23:48
Are you allowed to downvote because of superfluous regions , my OCD says yes :/ — TheGeneral
– TheGeneral, Commented May 31, 2018 at 23:56
You should stick to naming variables consistently (one language only (i.e. English)) — Ivan García Topete
– Ivan García Topete, Commented Jun 1, 2018 at 0:27

The Lyrist · Accepted Answer · 2018-06-01 01:03:58Z

Since it looks like a homework, I am not writing out the exact code but try to help you with some hints.

The Person class is probably not written properly.

If you want each person to have its own name and address, the fields shouldn't be static.

The Student class is probably not written properly.

The person object already contains the name and address field. The student object inherits from it so you just need to add the personal number as another attribute. (i.e., you probably don't need the array within the Student class)
You will need to update your constructor once you have fixed the parent class
Once you finish properly coding the Person and Student class, you should then be able to create an array of 3 Student object in your main code

Edit: I have a proof of concept (tio.run) fix with examples for class inheritance (method override, etc.). Please let me know if I should share it here. Thanks!

Erik Levin · Accepted Answer · 2018-05-31 23:50:04Z

1

You should assign StudentenA in the constructor, so that it takes place after setting the _name and _address.

public Studenten (string name, string address)
{
    Person._name = name;
    Person._address = address;
    StudentenA = new string[3] { Person._name, Person._address, personalnumber };
}

But also, _name and _address of Person shouldn't be static. With static, only one instance of them exists - not all persons have the same name and address, do they? :)

answered May 31, 2018 at 23:50

Erik Levin

471 silver badge4 bronze badges

Collectives™ on Stack Overflow

How do you create an Array for every Object and add it to a List (c#)

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related