Strange validator behaviour in AngularJS 1.5.11

Question

Our application is still using AngularJS 1.5.11 but I've tested the included example also with version 1.7.2 and get the same results.

The problem is the strange behavior of the validateNumber function. The validation seems to be flipping between true and false for each character typed. The validateMin and validateMax functions are working as expected.

The example code can be found here: https://codepen.io/kdbruin/pen/MBmXYz

Any insights as to why this is happening?

jsruok · Accepted Answer · 2018-07-24 10:31:16Z

1

Maybe this is the culprit?

test() called multiple times on the same global regular expression instance will advance past the previous match.

MDN

Easiest fix might be to change

var result = numberRegexp.test(modelValue);

to

var result = numberRegexp.search(modelValue) !== -1;

answered Jul 24, 2018 at 10:31

jsruok

5457 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kees de Bruin Over a year ago

Found the answer already and it seems that the "g" (global) flag is causing this. But I will try your suggestion as well.

Kees de Bruin · Accepted Answer · 2018-07-24 10:31:23Z

0

It seems that the regular expression is at fault here. When using

var numberRegexp = new RegExp("^[-+]?\\d+(" + (decimalSeparator === "." ? "\\." : decimalSeparator) + "\\d*)?$", "i");

the problem disappears. So it seems that the original "g" flag should not be used.

answered Jul 24, 2018 at 10:31

Kees de Bruin

5816 silver badges25 bronze badges

Collectives™ on Stack Overflow

Strange validator behaviour in AngularJS 1.5.11

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related