Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult'

Question

I have an asp.net core 2.1 project and I'm getting the following error in my controller action:

Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult' to 'System.Collections.Generic.IList'. An explicit conversion exists (are you missing a cast?)

This is my code:

[HttpPost("create")]
[ProducesResponseType(201, Type = typeof(Todo))]
[ProducesResponseType(400)]
public async Task<IList<Todo>> Create([FromBody]TodoCreateViewModel model)
{
    if (!ModelState.IsValid)
    {
        return BadRequest(ModelState);   // This is the line that causes the intellisense error
    }

    await _todoRepository.AddTodo(model);
    return await GetActiveTodosForUser();
}


[HttpGet("GetActiveTodosForUser")]
[ProducesResponseType(200)]
[ProducesResponseType(404)]
public async Task<IList<Todo>> GetActiveTodosForUser(string UserId = "")
{
    if (string.IsNullOrEmpty(UserId))
    {
        UserId = HttpContext.User.FindFirstValue(ClaimTypes.Sid);
    }
    return await _todoRepository.GetAll(UserId, false);
}

What am I doing wrong?

Your function is written to return Task<IList<Todo>> and BadRequest(ModelState) obviously inst't of that type — Matěj Štágl
– Matěj Štágl, Commented Aug 13, 2018 at 7:15

amankkg · Accepted Answer · 2018-08-13 07:20:06Z

29

Your action return type does not take in mind possible BadRequest.

Instead of direct usage of IList<Todo> you need to wrap it with generic ActionResult type.

public async Task<ActionResult<IList<Todo>>> Create(...

Here are the related docs.

edited Aug 13, 2018 at 7:20

answered Aug 13, 2018 at 7:17

amankkg

5,1771 gold badge22 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

spottedmahn · Accepted Answer · 2020-03-17 00:40:42Z

For ASP.NET Core 2.1, you should use ActionResult<T> but there is a limitation with Interface's.

This Works

public ActionResult<IList<string>> Create()
{  
    return new List<string> { "value1", "value2" };
}

Doesn't Work

public ActionResult<IList<string>> Create()
{
    //DOESN'T COMPILE:
    //Error CS0029  Cannot implicitly convert type
    //'System.Collections.Generic.IList<string>' 
    //to 'Microsoft.AspNetCore.Mvc.ActionResult<System.Collections.Generic.IList<string>>'
    //the cast here is for demo purposes.
    //the problem will usually arise from a dependency that returns
    //an interface.
    var result = new List<string> { "value1", "value2" }
                     as IList<string>;
    return result;
}

C# doesn't support implicit cast operators on interfaces. Consequently, conversion of the interface to a concrete type is necessary to use ActionResult.

Source: ActionResult type

Demo project
Interesting read on C# doesn't support implicit cast operators on interfaces

Sidenote: you don't need [FromBody] as ASP.NET will do that automatically. More here.

Muhammad Waqas Dilawar · Accepted Answer · 2018-08-13 07:30:44Z

9

Actually you need to return IActionResult instead of IList for below ASP.NET Core 2.1,

public async Task<IActionResult> Create([FromBody]TodoCreateViewModel model)

Then it will work.

And for ASP.NET Core 2.1 as suggested by @amankkg,

public async Task<ActionResult<IList<Todo>>> Create([FromBody]TodoCreateViewModel model)

edited Aug 13, 2018 at 7:30

answered Aug 13, 2018 at 7:18

Muhammad Waqas Dilawar

2,4121 gold badge26 silver badges36 bronze badges

7 Comments

amankkg Over a year ago

There is a generic ActionResult in ASP.NET Core 2.1

Robbie Mills Over a year ago

I want to create the ToDo then return the list of all the ToDos for the user which is why I'm returning a List

spottedmahn Over a year ago

can't use interface's w/ ActionResult. More here

Muhammad Waqas Dilawar Over a year ago

@spottedmahn I'm using Interfaces with ActionResult, then how you can say that it doesn't work. ActionResult<IEnumerable<PartViewModel>> Get(), Working example is here: devniggaspk.azurewebsites.net/admin/api/course/1/Clips/…

spottedmahn Over a year ago

Weird, it didn't work for me and the documentation says it doesn't work either.

|

Collectives™ on Stack Overflow

Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult'

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related