Javascript eval

Question

I am trying to get the following working. It seemed to work initially, but somehow it stopped working

var setCommonAttr = "1_row1_common";
var val = document.getElementById("abc_" + eval("setCommonAttr")).value;

what is wrong with above?

The above code is little different from what I am trying to accomplish. I gave the above example just not to make things complicated here. Below is what I am trying to accomplish:

First I am getting an existing element as follows. The element is a

<tr id="row_1_4_2009_abc" class="rowclick">
   <td></td>
</tr>

I am using jquery to get the id on click of a row:

$(".rowclick").click(function() {
  var row_id = $(this).attr("id");
  var getAttributes = row_id.split("_");
  var setCommonAttr = getAttributes[1] + "_" + getAttributes[2] + "_" + getAttributes[3] + "_" + getAttributes[4];
  var new_row_id = document.getElementById("new_row_" + setCommonAttr).value;
});

I don't understand what you're trying to do - you're evaling a string literal. Also, why not just var val = document.getElementById("abc_" + setCommonAttr).value; — no.good.at.coding
– no.good.at.coding, Commented Mar 13, 2011 at 4:00
What do you expect to get from document.getElementById("new_row_" + setCommonAttr).value; ? is it an input field? — Martin Jespersen
– Martin Jespersen, Commented Mar 13, 2011 at 4:47

Zach · Accepted Answer · 2011-03-13 03:59:27Z

2

You shouldn't need eval() to do this. The value you want is already a variable in JavaScript. Try:

var setCommonAttr = "1_row1_common";
var val = document.getElementById("abc_" + setCommonAttr).value;

answered Mar 13, 2011 at 3:59

Zach

7,9503 gold badges23 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DG3 Over a year ago

I edited my question with another sample code to show what I am trying to do

Dre · Accepted Answer · 2011-03-13 04:35:30Z

0

Will everything be in that form? row_xxx_xxx_xxx_xxx

if so, why not var new_row_id = document.getElementById("new_" + row_id).value;

answered Mar 13, 2011 at 4:35

Dre

4,34933 silver badges39 bronze badges

2 Comments

DG3 Over a year ago

no, I am cutting the first part in row_id. I am splitting "row_id" and ignoring the first part when forming other ids.

Dre Over a year ago

Yes, but the first components of the new ID, in your example are 'new_row_', so you have 'new_' + 'row_.....' which is the same thing as stripping off the first component ( 'row_' ) and adding 'new_row_' to the beginning -- if everything doesn't have 'row_' at the beginning, then this wouldn't work,

Mike Lewis · Accepted Answer · 2011-03-13 03:59:24Z

0

You don't need to call eval().

You can just concatenate the string with the variable:

var setCommonAttr = "1_row1_common"; var val = document.getElementById("abc_" +   setCommonAttr).value;

answered Mar 13, 2011 at 3:59

Mike Lewis

64.3k20 gold badges144 silver badges111 bronze badges

Collectives™ on Stack Overflow

Javascript eval

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related