Returning Multiple Objects in one Method

Question

My problem is quite simple example has two methods. One returns an Account and another a Customer object.

I have about 10 other different requests that should be made for a WebApp page.

Is it correct to make 10 different requests on the WebApp or just create 1 with everything that I need?

If so, what is the correct way to do this? Do I need to create a custom object that holds all the other objects that I need in the page and then return it or is there a better way?

What is the correct approach?

@GetMapping("/customer")
public Customer getCustomer(@RequestParam String customerNumber) {
    return customer.getCustomer(customerNumber);
}

@GetMapping("/account")
public Account getAccountFromCustomer(@RequestParam String customerNumber, @RequestParam String accountNumber) {
    return account.getAccountFromCustomer(customerNumber, accountNumber);
}

There is no correct approach, I think. If you need all these objects at once in every case, then creating a holder object for all would be appropriate. Otherwise you better create different requests. Performance should be taken into account, too. — deHaar
– deHaar, Commented Jan 4, 2019 at 9:18
I was thinking making a custom object for each page that I have, with everything needed, but I think it's kinda messy — user10866653
– user10866653, Commented Jan 4, 2019 at 9:19
I agree there is no correct way to do this, but minimising the number of calls to the server would be a good place to start. — Luke Garrigan
– Luke Garrigan, Commented Jan 4, 2019 at 9:20
This question covers several aspects of quality. Readability and testability of code are among them as well as performance. — deHaar
– deHaar, Commented Jan 4, 2019 at 9:27

davidxxx · Accepted Answer · 2019-01-04 09:26:03Z

1

You define an API according to the client requirements.
For this point, REST services are not different of service.
Why expose 10 operations that the client has to invoke to gather the result if you can return to it the aggregated result ? Besides HTTP requests are not "free".

As a side note, API has to be unitary tested and REST service are API. In your case you will need to test 10 methods instead of a 1.

All that seems not the right path.
So yes in your case favor object aggregation to multiple requests.

Note that in some cases you want to define very fine grained operations but only when the client may need to request just one entity and not a graph of objects.
It is not your case, keep the things simple.

answered Jan 4, 2019 at 9:26

davidxxx

132k23 gold badges231 silver badges228 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

leftbit · Accepted Answer · 2019-01-04 09:29:52Z

0

You might want to think about the object relationship between Customer and Accounts. Usually a Customer would aggregate zero to many Accounts and youl'd retrieve Accounts via the Customer object.

What is your use case? Does it make sense to work retrieve an Account without corresponding Customer data? If not, you don't need a custom object holder because the Customer fulfills that role nicely.

Of course your buisiness case might differ...

answered Jan 4, 2019 at 9:29

leftbit

8281 gold badge7 silver badges18 bronze badges

Collectives™ on Stack Overflow

Returning Multiple Objects in one Method

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related