ASP.NET Core MVC + Entity Framework + GET + Array

Question

I'm doing some tests to take a project. I have been working with ASP.NET Core MVC and Entity Framework relatively recently. I have a simple database in SQL Server to prove how it is:

In the test project I have a controller TestController; the code is this:

using Microsoft.AspNetCore.Mvc;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.EntityFrameworkCore;
using WEBAPPHTTP.Models;

namespace WEBAPPHTTP.Controllers
{
    [Route ("api/controller[]")]
    public class TestController: Controller
    {
        [HttpGet("/api/values")]
        public IEnumerable<string> Get()
        {
            using (TareasContext db = new TareasContext())
            {
                var listar = db.Tareas;
                var n = listar.Count();

                string[] array = new string[n+1];
                int i = 0;
                foreach (var otareas in listar)
                {
                    array[i] = otareas.Tarea.ToString();
                    i = i++;
                }

                return array;
            }
        }
    }
}

Obviously I'm doing something wrong but the output is this:

in localhost/api/values:

["ahora",null,null,null,null]

It only shows me the last record of the database followed by a few NULL, this test the idea is that all the results are loaded in the array.

I'm sure it's a very early mistake, I hope you can guide me.

i = i++; looks very strange and wrong. You assign i to i and then increment i. — Uwe Keim
– Uwe Keim, Commented Feb 2, 2019 at 18:01

Andreas Gustafsson · Accepted Answer · 2019-02-02 18:08:32Z

2

I dont know what you want to do after this, but if you just want to list out your items, you should be able to do something like this:

using (TareasContext db = new TareasContext())
        {
            return db.Tareas.ToList();

        }

That will give you the full list with all items in it with all properties, if you want just a part of your properties I would suggest to do a .Select as well. Remember to do a where as well so you dont always return the full list (if it gets enourmus big)

Peace!

answered Feb 2, 2019 at 18:08

Andreas Gustafsson

3213 gold badges5 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dmitry Stepanov · Accepted Answer · 2019-02-02 18:22:33Z

2

You code is not efficient. This is the much cleaner version that does the same:

using (TareasContext db = new TareasContext())
{
    var result = db.Tareas.Select(x => x.Tarea).ToList();
    return result;
}

As I see the Tarea column is of varchar or nvarchar type. So, you don't need to cast it to string.

answered Feb 2, 2019 at 18:22

Dmitry Stepanov

2,9748 gold badges36 silver badges47 bronze badges

Collectives™ on Stack Overflow

ASP.NET Core MVC + Entity Framework + GET + Array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related