Improve Python if conditional [closed]

Question

Closed. This question needs details or clarity. It is not currently accepting answers.

Want to improve this question? As written, this question is lacking some of the information it needs to be answered. If the author adds details in comments, consider editing them into the question. Once there's sufficient detail to answer, vote to reopen the question.

Closed 6 years ago.

Improve this question

How to improve the following if conditional in Python 3.6 to one line.

def run_cmd(beta: bool): {
  cmd = "cloud create {}".format(self.name)
  if beta:
    cmd = "cloud beta create {}".format(self.name)
}

Just remove the if statement since you are setting beta to False and there is nothing in your code that will change that. — Red Cricket
– Red Cricket, Commented Feb 9, 2019 at 23:27
Something like cmd = "cloud beta create {}".format(self.name) if beta else "cloud create {}".format(self.name)? That's assuming, of course, the value of beta could change. — Chris
– Chris, Commented Feb 9, 2019 at 23:30
Well in the same way they could just go for cmd = "cloud create " because beta is false and name is empty :) Bad question — Piotr Dabkowski
– Piotr Dabkowski, Commented Feb 9, 2019 at 23:30
if beta was not staticly fixed: cmd = "cloud {}create {}".format("beta " if beta else "", self.name) — Patrick Artner
– Patrick Artner, Commented Feb 9, 2019 at 23:30
OP, I'm afraid your question is currently somewhat confusing. It would probably be best to reformulate your question and clearly state what you're trying to achieve. — Chris
– Chris, Commented Feb 9, 2019 at 23:33

John Keyes · Accepted Answer · 2019-02-09 23:30:56Z

1

The following one liner will achieve it:

cmd = "cloud {}create {}".format("beta " if beta else "", name)

answered Feb 9, 2019 at 23:30

John Keyes

5,6142 gold badges33 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rene-d · Accepted Answer · 2019-02-09 23:30:43Z

1

One way to achieve this:

cmd = "cloud{} create {}".format(["", " beta"][beta], self.name)

answered Feb 9, 2019 at 23:30

rene-d

3431 silver badge6 bronze badges

3 Comments

Piotr Dabkowski Over a year ago

Is it really better? Much less readable. Not always converting things to one line make things better.

John Keyes Over a year ago

I prefer explicit stuff, so for me I would leave it as is in the original question. I like using the boolean as the index though. Neat.

rene-d Over a year ago

better = more efficient ? I don't know. better = more readable ? I don't know too :) It depends... You even can write this f"cloud {'beta ' if beta else ''}create {name}" in Python3 (since you prefer the A if cond else B construction).

Alan Kavanagh · Accepted Answer · 2019-02-09 23:31:05Z

1

If you want to reduce the if statement:

name = ''
beta = True

cmd = "cloud beta create {}".format(name) if beta else "cloud create {}".format(name)

answered Feb 9, 2019 at 23:31

Alan Kavanagh

9,9338 gold badges46 silver badges68 bronze badges

Collectives™ on Stack Overflow

Improve Python if conditional [closed]

3 Answers 3

Comments

3 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Related