Php Problem with move_uploaded_file. It seems everything is fine but it is not working

Question

I am trying to use move_uploaded_file but I think everything is fine but my code is not working. Everything is working as expected even image name is being inserted into DB but it is not moving into uploads folder. Folder is there and apache2 does have access to write it.

I don't have enough reputation to post more then 8 lines so everything is on pastebin Here. The main aprt is...

 $post_image_new_name = uniqid('', true). "." 
.$post_image_actual_ext;

                $post_image_destination = '../../uploads/';
                    if (is_dir($post_image_destination) && is_writable($post_image_destination)) {

                    $post_image_destination = '../../uploads/'.$post_image_new_name;
                    var_dump($post_image_destination);
                    move_uploaded_file($post_image_new_name, $post_image_destination);
                    echo "Inside move_uploaded_file section";

https://pastebin.com/Z321R76z

Hint: move_uploaded_file() expects the source filename of the uploaded file. It is usually member $_FILES[...]->tmp_name. — Wiimm
– Wiimm, Commented Apr 21, 2019 at 16:39
Warning Please validate Formats before placing them in your directory, any attacker can use this way to upload any type of file. See acunetix.com/websitesecurity/upload-forms-threat — weegee
– weegee, Commented Apr 21, 2019 at 19:52
Thanks dude I didn't knew such an attack is possible and yes you are right I am a new learner. — Mahad Ali
– Mahad Ali, Commented Apr 22, 2019 at 5:56

Fatih khan · Accepted Answer · 2019-04-21 19:27:51Z

2

Try this code line 53: move_uploaded_file($_FILES['addPost_post_image']['tmp_name'], $post_image_destination);

The first param should be the file source name.

answered Apr 21, 2019 at 19:27

Fatih khan

841 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mahad Ali Over a year ago

Thanks brother it has been solved. The problem is as you said it to be. I would love to add a plus but I lack reputation to do so :)

Fatih khan Over a year ago

Thank you @MahadAli

Mahad Ali Over a year ago

Can you upvote my post? lol I got banned from posting question :D

Morteza Pouretemadi · Accepted Answer · 2019-04-21 19:49:51Z

1

move_uploaded_file() expects the source filename of the uploaded file. So you must use something like this:

move_uploaded_file($_FILES['addPost_post_image']['tmp_name'], $post_image_destination);

answered Apr 21, 2019 at 19:49

Morteza Pouretemadi

6484 silver badges12 bronze badges

Collectives™ on Stack Overflow

Php Problem with move_uploaded_file. It seems everything is fine but it is not working

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related