Why the if statement doesn't work in an Image button?

Question

Hello Guys im new on this Website so if I make any mistakes please forgive me. For the School I need to code an App and I want to code an app like the old Egg app where you needed to click on for like 1.000.000 times.

My Counter works but I wanted to let the Egg break. For this I wanted to use an if statement so I can make it break after like 200 times and so on.

My Problem is that if I'm pressing the button the Image switch in the first time. Not as I expected in the third time

Do anyone knows what my problem is?

PS: I'm new in java so maybe the code isn't sexy

package com.example.die_vierte;

import android.content.Intent;
import android.media.Image;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.Menu;
import android.view.View;
import android.webkit.SafeBrowsingResponse;
import android.widget.Button;
import android.widget.ImageButton;
import android.widget.TextView;


public class MainActivity extends AppCompatActivity {

    private Object TextView;

    int eggcounter;
    ImageButton ImgButton;

    android.widget.TextView textClicks;
    private Object SafeBrowsingResponse;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        eggcounter = 10000000;
        final ImageButton ImgButton = findViewById(R.id.eggBtn);

        ImgButton.setOnClickListener(
                new View.OnClickListener() {

                    public void onClick(View view) {
                        eggcounter = eggcounter - 1;
                        updateEgg();

                        if (eggcounter > 999998) {

                            ImgButton.setImageResource(R.drawable.egg_2);
                        }

                    }
                }
        );

    public void updateEgg() {
        textClicks = (TextView) findViewById(R.id.textScore);
        textClicks.setText(eggcounter + " ");

    }

Your counter is always greater than 999998 that is why it always works the first time, and there is no else statement after the if — Anga
– Anga, Commented Apr 28, 2019 at 0:32

Moonbloom · Accepted Answer · 2019-04-27 23:59:54Z

1

The first time you click on the button, the 'eggcounter' is at 999999.
That is more than 999998, so the if statement is true, thus the image is changed.

I'm guessing that you should change the '>' to a '<' so the image isn't changed until the 3rd click.

answered Apr 27, 2019 at 23:59

Moonbloom

7,9683 gold badges29 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

KinqNick Over a year ago

If im doing this the image never change.

Moonbloom Over a year ago

Check the numbers. You're using '10000000' and '999998' First number is 10 million, the second is just under a million. So you'd need to click the button just over 9 million times. I'm guessing you meant to input '1000000' instead.

KinqNick Over a year ago

oh yes youre right didnt notice how much numbers there are i just pressed the 0. Thank you <3 much love

ismail alaoui · Accepted Answer · 2019-04-28 00:09:44Z

0

First of all , you .setText() method isn't correct ,you should use it like that :

textClicks.setText(String.valueOf(eggcounter)+" ");

and for your issue you should use your if statement like this :

 if (eggcounter < 9999998) {
      ImgButton.setImageResource(R.drawable.egg_2);
   }

answered Apr 28, 2019 at 0:09

ismail alaoui

6,1052 gold badges26 silver badges42 bronze badges

Collectives™ on Stack Overflow

Why the if statement doesn't work in an Image button?

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related