Rails 5 app won't load JS from assets/javascripts folder

Question

As I understand it any js file in the assets/javascripts folder is loaded if /= require_tree is present in the application.js file. I can't get my JS code to work, however. I have put it in assets/javascripts/locations.js and it doesn't work. When I put it in a script tag in my application.html.erb file it worked perfectly on the other hand. Any ideas what I could be missing? Running Rails 5.2. The JS code is below.

locations.js

var locations = ["coordinatesStore"]
  .map(id => document.getElementById(id));

Array.prototype.forEach.call(
  document.querySelectorAll('.add-button'),
  (button, i) => {
    button.addEventListener('click', () => getLocation(i));
  }
);

function getLocation(i) {
  var location = locations[i];
  if (navigator.geolocation) {
    navigator.geolocation.getCurrentPosition(({ coords: { latitude, longitude }}) => {
      location.value = latitude + ", " + longitude;
    });
  } else { 
    location.value = "Geolocation is not supported by this browser.";
  }
}

I have this tag in my application.html.erb

<%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>

Holino · Accepted Answer · 2019-05-05 11:29:26Z

1

Where is <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %> in your application.html.erb ?

Try putting it at the end of your body tag, at least after the <%= yield %>

answered May 5, 2019 at 11:29

Holino

864 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Steve Over a year ago

Why is the tag in the head section of the erb file by default?

Holino Over a year ago

Because that's, by default and conventions, where the <script> tag to include an external .js file belongs. But "recently" (kind of), the best way was to include it after the HTML to not block the rendering of your page by loading external .js files. In your case, as the code is executed as soon it was imported, your javascript was run before there was any HTML in the page, so it wasn't working !

Steve Over a year ago

So the default setting is going to cause this same issue with everyone using Rails?

Collectives™ on Stack Overflow

Rails 5 app won't load JS from assets/javascripts folder

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related