Django View Value Error

Question

I'm hitting a wall with this error. I'm sure I'm overlooking something basic, just can't seem to figure it out...

ValueError at /sing/register

The view sing.singer.views.grade didn't return an HttpResponse object.

the view file...

from django.shortcuts import render_to_response
from django import forms
from django.http import HttpResponseRedirect
from django.template import Template, RequestContext
from dash.forms import GradeForm


def register(request):
    if request.method == 'POST':
        form = GradeForm(data=request.POST)
        if form.is_valid():
            new_dash_profile = form.save()
            new_user = form.save()
            return  HttpResponseRedirect("/success/")
        else:
            form = RegisterForm()
        return render_to_response('grade.html',{'form':form},context_instance=RequestContext(request) )

my urls.py

urlpatterns = patterns('dashboard.dash.views',
 (r'^sing/register','register' ),)

my settings.py

TEMPLATE_DIRS = (
    "/home/django/testing/sing/grade/templates",)

dting · Accepted Answer · 2011-04-17 23:59:27Z

4

def register(request):
    if request.method == 'POST':
        form = GradeForm(data=request.POST)
        if form.is_valid():
            new_dash_profile = form.save()
            new_user = form.save()
            return  HttpResponseRedirect("/success/")
    else:
        form = RegisterForm()
    return render_to_response('grade.html',{'form':form},context_instance=RequestContext(request) )

your indents look off?

Initially you are entering the view with request != 'POST' which will never reach that else statement at the bottom, so you dont get a HttpResponse.

The other thing that looks strange is even if you fix your indents, you show the RegisterForm initially, and after the post request, you put the data from your RegisterForm into a GradeForm, if that doesn't validate you show pass your GradeForm to your template. Is this what you intended?

also in your urls.py I would add / to:

(r'^sing/register','register' ),)

like:

(r'^sing/register/','register' ),)

unless you want it to match (for example):

www.site.com/sing/registerasdf/

i might even suggest using '/$' at the end like this:

(r'^sing/register/$','register' ),)

to prevent matches to (for example):

www.site.com/sing/register/asdf/asdf/asdf/
www.site.com/sing/register/asdf/asdf/
www.site.com/sing/register/asdf/

edited Apr 17, 2011 at 23:59

answered Apr 17, 2011 at 23:42

dting

39.4k10 gold badges98 silver badges117 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Eva611 Over a year ago

wow. it was the indenting indeed! total blonde moment! Thanks @DTing!

miken32 · Accepted Answer · 2022-10-15 19:24:02Z

1

Judging from the code, the only time it does not return a HttpResponse is when it's not a POST request. Maybe you are doing a GET instead?

edited Oct 15, 2022 at 19:24

miken32

42.5k16 gold badges127 silver badges177 bronze badges

answered Apr 17, 2011 at 23:39

Uku Loskit

42.2k9 gold badges97 silver badges98 bronze badges

Comments

James Khoury · Accepted Answer · 2011-04-17 23:44:12Z

0

I think its your HttpResonseRedirect. I can't say I've used it that often (if at all). If I were you I would try shortcut redirect

http://docs.djangoproject.com/en/dev/topics/http/shortcuts/#redirect

answered Apr 17, 2011 at 23:44

James Khoury

22.6k4 gold badges36 silver badges66 bronze badges

4 Comments

dting Over a year ago

docs.djangoproject.com/en/dev/ref/request-response/…

James Khoury Over a year ago

@DTing Thats interesting and I'm not sure what you were trying to say.

dting Over a year ago

Sorry, since hes just passing an URL there's no reason for him to use the redirect shortcut.

James Khoury Over a year ago

@DTing You're probably right!.. I also didn't notice the indenting you pointed out that would make a difference. I just happen to like the shortcuts.

Collectives™ on Stack Overflow

Django View Value Error

3 Answers 3

1 Comment

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related