cpp too many initializers - struct in struct in array

Question

I'm new to cpp since a few days and struggling with the following definition:

struct menuItem {
    char* name;
    int value;
};

struct topMenu {
    int menuIcon;
    char* Name;
    menuItem item[];
};

topMenu menuRoot[] = {
    { 0, "File", 
        {"Open ...", 1},
        {"New ...", 4},
        {"Close", 1},
        {"Exit", 3}

    },
    { 0, "Edit", 
        {"Cut ", 3},
        {"Copy", 8},
        {"Paste", 2},
        {"Find", 1},
        {"Replace", 6}

    },
    { 0, "Help", 
        {"Help", 7},
        {"About", 9},
        {"Update ..", 9}
    }  
};

I receive the error

33:1: error: too many initializers for 'menuItem [0]'
33:1: error: too many initializers for 'topMenu'
33:1: error: too many initializers for 'menuItem [0]'
33:1: error: too many initializers for 'topMenu'
33:1: error: too many initializers for 'menuItem [0]'
33:1: error: too many initializers for 'topMenu'

Sorry, i'm a little bit stuck ... maybe its just to late :) Thanks in advance.

[Off topic] Do not use a char* to point to string literals. It was deprecated in C++03 and removed in C++11. Either use a const char* or a std::string/std::string_view — NathanOliver
– NathanOliver, Commented Jul 10, 2019 at 21:33
You need to wrap each menuItem array in an additional { ({{"Help", 7}, {"About", 9}, {"Update ..", 9}}). — Michael Bianconi
– Michael Bianconi, Commented Jul 10, 2019 at 21:35
What do you expect from menuItem item[];? should it be std::vector instead? — Jarod42
– Jarod42, Commented Jul 10, 2019 at 21:41
Remember that size of arrays in C++ has to be determined at compile time. — HolyBlackCat
– HolyBlackCat, Commented Jul 10, 2019 at 21:52
menuItem item[]; is not allowed in Standard C++, you must specify a size (or use a different construct altogether) — M.M
– M.M, Commented Jul 10, 2019 at 22:57

pledab · Accepted Answer · 2019-07-10 22:39:07Z

2

First, wrap the menuItem item[] array in {} because currently it thinks there are many arrays rather than just one.

Next, change the char * to const char * as was mentioned.

Now for the flexible amount of menuItem structs, use a vector rather than an array.

#include <vector> 

struct menuItem {
    const char *name;
    int value;
};

struct topMenu {
    int menuIcon;
    const char *Name;
    std::vector<menuItem> item;
};

topMenu menuRoot[] = {
    { 0, "File", {
        {"Open ...", 1},
        {"Open ...", 1},
        {"Open ...", 1},
        {"Open ...", 1},
    }
    },
    { 0, "Help", {
        {"Open ...", 1},
        {"Open ...", 1},
        {"Open ...", 1}, }
    }
};

edited Jul 10, 2019 at 22:39

answered Jul 10, 2019 at 21:47

pledab

1201 silver badge13 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

pledab Over a year ago

My bad, just laziness on my part.

robb30 Over a year ago

The menu is basically static (won't be changed during runtime ( - yet)). Therefore i could set all sizes. But i just thought there was another way. Since it will be use on an embedded system, i've care about memory. Thanks!

Collectives™ on Stack Overflow

cpp too many initializers - struct in struct in array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related