Javascript cut string after 3th character in string

Question

I need to write function that returns 3strings after character ', ' so if there is none or 1 or 2 or 3 to return empty string if ', ' character is found else return 3 strings...i wrote these function but it is very cpu intensive...can be shorter and faster code?

https://jsfiddle.net/1nfyq327/

    var str = 'AAA BBB CC., DD EE, FF FF, GG GG, HH HH, II II, JJ JJ, GG GG';

    var res = str.substring(0, str.indexOf(', ', str.indexOf(', ', str.indexOf(', ')+1)+1));

    console.log(res);

Result is:

AAA BBB CC., DD EE, FF FF

Result is fine but i need faster code because it will execute on low power cpu so speed is very cruicial...

u can split on ', ' and merge 3 item, but better soulotion for problem like this is regular expression — Nozar Safari
– Nozar Safari, Commented Oct 23, 2019 at 10:02

apomene · Accepted Answer · 2019-10-23 10:08:30Z

1

Use split , slice and join:

var str = 'AAA BBB CC., DD EE, FF FF, GG GG, HH HH, II II, JJ JJ, GG GG';


var result = str.split(',').slice(0,3).join(',');

console.log(result);

answered Oct 23, 2019 at 10:08

apomene

14.4k10 gold badges51 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Simon Kocurek · Accepted Answer · 2019-10-23 10:03:42Z

1

In terms of speed there is not that much you can do.
The code you wrote runs in O(n), which is the best possible time complexity for your problem.

You can play around with native functions (split(), substring()... that are implemented in c++ and therefore will run quickly) to see if one of them is faster, or rewrite it in pure javascript with a for loop. And compare the results.

In your case the best thing you can really do is write a little benchmark testing how fast your solution is and compare that. Althought there is high chance that there is something else in your code that runs slowly. :)

answered Oct 23, 2019 at 10:03

Simon Kocurek

2,1862 gold badges15 silver badges26 bronze badges

Comments

Nina Scholz · Accepted Answer · 2019-10-23 10:14:08Z

1

You could split with a limit of String#split and join the array.

var string = 'AAA BBB CC., DD EE, FF FF, GG GG, HH HH, II II, JJ JJ, GG GG',
    result = string.split(',', 3).join(',')

console.log(result);

answered Oct 23, 2019 at 10:14

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Collectives™ on Stack Overflow

Javascript cut string after 3th character in string

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related