Writing a program and need some input

Question

I am doing a program about creating a file about golf, it allows only one For. When I run the program I get an error about Golf_File.write(Name + ("\n") ValueError: I/O operation on closed file.

Num_People = int(input("How many golfers are playing?: "))
Golf_File = open('golf.txt', 'w')

for count in range(1,Num_People+1):
    Name = input("Enter the player's name: ")
    Score = int(input("Enter the player's score: "))
    Golf_File.write(Name + ("\n"))
    Golf_File.write(str(Score) + ("\n"))

    Golf_File.close()

Jeril · Accepted Answer · 2020-02-07 02:22:54Z

1

The following will work:

Num_People = int(input("How many golfers are playing?: "))
Golf_File = open('golf.txt', 'w')

for count in range(1,Num_People+1):
    Name = input("Enter the player's name: ")
    Score = int(input("Enter the player's score: "))
    Golf_File.write(Name + ("\n"))
    Golf_File.write(str(Score) + ("\n"))

Golf_File.close()

The file should be closed outside the for loop

answered Feb 7, 2020 at 2:22

Jeril

8,6316 gold badges60 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hymns For Disco · Accepted Answer · 2020-02-07 03:02:14Z

0

It is generally considered better to use with statements to handle file objects

Num_People = int(input("How many golfers are playing?: "))

with open('golf.txt', 'w') as Golf_File:
    for count in range(1,Num_People+1):
        Name = input("Enter the player's name: ")
        Score = int(input("Enter the player's score: "))
        Golf_File.write(Name + ("\n"))
        Golf_File.write(str(Score) + ("\n"))

You can read more about this in the Python documentation about reading and writing files

Also obligatory reminder about the official Python naming standards, capitalized variable names should be avoided

answered Feb 7, 2020 at 3:02

Hymns For Disco

8,5052 gold badges26 silver badges42 bronze badges

Collectives™ on Stack Overflow

Writing a program and need some input

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related