Django REST Framework: Using the Accept-Language header to set an instance's "locale"

Question

So, I have a model with the following attribute:

locale = models.CharField(max_length=10, choices=get_locale_choices(), default='en-gb')

The associated serializer for this model is currently:

class MyModelSerializer(serializers.ModelSerializer):
    class Meta:
        model = MyModel
        fields = '__all__'

I then call a create endpoint:

serializer = self.get_serializer(data=request.data)

serializer.is_valid(raise_exception=True)

self.perform_create(serializer)

I was wondering, how best to modify the above to allow the locale attribute of MyModel to be updated by the Accept-Language header en-GB,en;q=0.5.

I get my locale choices from django.conf.locale.LANG_INFO:

from django.conf.locale import LANG_INFO

def get_locale_choices():
    return [(k, v['name']) for k, v in LANG_INFO.items() if 'name' in v]

I guess I need to pass in the request.headers as some sort of extra context...? But I'm thinking, what if the Accept-Language is not set, etc? I know it is here:

request.headers['Accept-Language']

So, I guess request.headers.get('Accept-Language', 'en-gb') would be acceptable ...

But then, what would be the best way to then set the attribute in the serialzier as this?

N.B. I also believe get_serializer_context() can return the request object?

I also feel this could be robust enough:

data = request.POST.copy()

serializer = self.get_serializer(data=data.update({'locale': request.headers.get('Accept-Language', 'en')}))

But is this, "good practise"?

Opinions are warmly welcome!

JPG · Accepted Answer · 2020-02-19 17:15:47Z

2

Without "much considering the locale" try this method to save any data from request.

First you need to set the locale field to read_only

class MyModelSerializer(serializers.ModelSerializer):
    class Meta:
        model = MyModel
        fields = '__all__'
        read_only_fields = ('locale',)

override the perform_create(...) method of the ModelViewset or similar viewclass

class MyModelViewSet(viewsets.ModelViewSet):
    # other code
    def perform_create(self, serializer):
        serializer.save(locale=self.request.headers.get('Accept-Language', 'en-gb'))

answered Feb 19, 2020 at 17:15

JPG

89.4k24 gold badges164 silver badges235 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Django REST Framework: Using the Accept-Language header to set an instance's "locale"

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related