How to — callback functions

Question

I have a big problem writing a small piece of code using JS/jQuery (don't know which of these is causing the problem). Anyhow, here we go:

$('#themePicker').unbind().click(function() {
    var t = $(this);    
    modalwindow2(t, function() {
        console.log(1);
    }, function(w) {
        console.log(w);
    });

    return false;
});

and the function itself:

function modalwindow2(w, callbackOnSHow, callbackOnHide) {
    if (typeof(callbackOnSHow) == 'function') {
        callbackOnSHow.call();
    }

    // do some stuff //
    $('form').submit(function() {
        ajaxSubmit(function(data) {
            if (typeof(callbackOnHide) == 'function') {
                console.log('---------------');
                console.log(data);
                console.log('---------------');
                callbackOnHide.call(data);
            }
        });

        return false
    });
}

The function is called modalwindow2 and I want to call a function when the modal is shown and another function when the modal will be hidden.

The first is not a problem.

The second… Well… Let's just say it's a problem. Why?

I want a parameter sent to the second function. The paramenter is an ajax response, similar to other jQuery stuff (ajax action, sortable, etc).

I hope I made myself clear enough.

Thanks!

Edit:

I'm using jQuery 1.1.2 (or 1.1.3) and upgrading or using jQuery UI is NOT a solution. I have some dependencies (interface is one of them) and i don't have enough time (nor motivation) to upgrade to 1.3 & UI 1.7.

Nick Jurista · Accepted Answer · 2009-03-02 23:05:28Z

1

I noticed that you have a typo on .submit: $('form').submti(function(){

Was that just an entry error to SO?

EDIT: Ok, so after looking at your code and doing a short test, I've come up with this (pardon the pun):

function modalwindow2(w, callbackOnShow, callbackOnHide) {
    if(typeof callbackOnShow == 'function') {
        callbackOnShow.call();
    }
    $('form').submit(function() {
        if(typeof callbackOnHide == 'function') {
            callbackOnHide.call(this, "second");
        }
    });
}

$(document).ready(function (){
    $('#themePicker').click(function(){
        var t=$(this);
        modalwindow2(t, function() { alert("first"); }, function(x) { alert(x); });
        return false;
    });
});

It looks like you may have just been missing the "this" in your call() statement. Try using callbackOnHide.call(this, data);

Let me know if that works any better!

edited Mar 2, 2009 at 23:05

answered Mar 2, 2009 at 19:58

Nick Jurista

1,44412 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ionuț Staicu Over a year ago

yeah, i just rewrite here a small example. the real code is waaay bigger :) Anyhow, thanks for the notice

jonstjohn · Accepted Answer · 2009-03-02 19:35:45Z

1

I understand what you are trying to do, but you will need to store the newly created window so that you can access it on the close callback function.

You might want to look at jQuery UI Dialog. It provides some really basic functionality for dialog windows (modal and otherwise) and handles some of the callback implementation.

answered Mar 2, 2009 at 19:35

jonstjohn

60.4k8 gold badges47 silver badges55 bronze badges

1 Comment

Ionuț Staicu Over a year ago

i can't use UI. I'm using an antique version of jquery and i cannot upgrade because i use interface (which mean max jquery 1.1.3 :( )

Collectives™ on Stack Overflow

How to — callback functions

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related