Simple function to convert decimal number to binary in Python

Question

I'm trying to convert a decimal number in binary but I can't seem to understand why my code doesn't work. Before checking it I need to precise that:

I am not allowed to use modulo, division, powers, or any libraries
that might help me to accomplish my goal.
I can use multiplication, addition, subtraction as well as comparisons.

That said, here is my code:

def binary_conv(n):
    p1 = 1
    p2 = 1
    lst = list()
    counter1 = 0
    counter2 = 0

    while p1 <= n:
        p1 *=2
        counter1 += 1

    len_bin = counter1
    lst = len_bin*[0]
    counter1 -= 1

    while n > 0:
        p2 *= 2
        counter2 += 1
        if (p2*2) == p1:
            lst[counter1-counter2] = 1
            p1 = p2
            p2 = 1
            n = n-p1
            counter2= 0


    print(lst)

If you need more clarifications, don't hesitate to ask.

doesn't work. What does that mean, specifically?

AMC
– AMC

2020-04-29 02:27:28 +00:00
Commented Apr 29, 2020 at 2:27 — AMC
– AMC, Commented Apr 29, 2020 at 2:27
I don't get the output wanted

MM1
– MM1

2020-04-29 09:40:53 +00:00
Commented Apr 29, 2020 at 9:40 — MM1
– MM1, Commented Apr 29, 2020 at 9:40

MM1 · Accepted Answer · 2020-04-29 09:49:18Z

1

I actually found the answer, here it is for those interested:

def binary_conv(n):
    p1 = 1
    p2 = 1
    lst = list()
    counter1 = 0
    counter2 = 0

    while p1 <= n:
        p1 *= 2
        counter1 += 1

    len_bin = counter1
    lst = len_bin*[0]
    counter1 -= 1

    while n > 0:
        p2 *= 2
        counter2 += 1
        if (p2 * 2) > n:
            if n == 1:
                lst[-1] = 1
                break
            lst[counter1 - counter2] = 1
            p1 = p2
            p2 = 1
            n = n - p1
            counter2 = 0

answered Apr 29, 2020 at 9:49

MM1

9441 gold badge11 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Simple function to convert decimal number to binary in Python

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related