Powershell: For each loop loop with list issues

Question

I am trying to loop the list through the function that i made. What I want to do with the loop is that the variable: "$huidige_folder" inside the function is filled with one location at a time that is in the list, loop and continue with the next location in the list

So first item in the list: "C:\Users\Nick\Desktop\Test1". It uses this location in the function
Then C:\Users\Nick\Desktop\Test2". It uses this location in the function
Then C:\Users\Nick\Desktop\Test3". It uses this location in the function

But when i run the code it will only run the function for the first item in the list. That works and it does what i want. But after that it stops and doenst run the funtion for the other 2 items in the list.

What am i doing wrong?

$path_dagelijkse_controle = "C:\Users\Nick\Desktop\Test1",
                            "C:\Users\Nick\Desktop\Test2", 
                            "C:\Users\Nick\Desktop\Test3"



function Dagcontrole_folders_maken {($huidige_folder)

$Dagelijkse_controle = "Dagelijkse controle"
$datum_vandaag = $(Get-Date).toString('yyyy-MM-dd')
$jaar = $datum_vandaag.Substring(0,4)
$maand = $datum_vandaag.substring(5, 2)
$dag = (get-date).DayOfWeek

$path_jaar = Get-Item -Path "$huidige_folder\**" -Include *$jaar*
$path_maand = Get-Item -Path "$huidige_folder\$jaar\**" -Include *$maand*
$folder_maand = Get-Date -UFormat "%m - %B"


if ($path_jaar) {
    Write-Output "Do Nothing"
}
Else {   
    md -Path "$huidige_folder\$jaar"   
}

if ($path_maand) {
  md -Path "$huidige_folder\$jaar\$folder_maand\Dagelijks\$datum_vandaag"  
}
Else {
    md -Path "$huidige_folder\$jaar\$folder_maand"                              # Makes the month folder
    md -Path "$huidige_folder\$jaar\$folder_maand\Dagelijks\$datum_vandaag"     # Makes a folder with current date inside the month folder
}

}


Foreach ($i in $path_dagelijkse_controle) {
    Dagcontrole_folders_maken($i)
    }

Change function Dagcontrole_folders_maken {($huidige_folder) to function Dagcontrole_folders_maken ($huidige_folder) { — Lieven Keersmaekers
– Lieven Keersmaekers, Commented Aug 6, 2020 at 12:08
You can simplify your code substantionaly by using md .. -Force. — Lieven Keersmaekers
– Lieven Keersmaekers, Commented Aug 6, 2020 at 12:11

Kluk · Accepted Answer · 2020-08-06 12:26:13Z

1

I would change the declaration of your function:

function Dagcontrole_folders_maken ([String]$huidige_folder) {

It means that $huidige_folder is declared as a String. But the main issue was the { character placed at the wrong place. It must be placed after the arguments.

I would also suggest you to parse all the elements within your function. You can write your ForEach into the function and give an array of strings as an argument. That way, your function would work with one or more elements.

function Dagcontrole_folders_maken ([String[]]$huidige_folder) {
ForEach($folder in $huidige_folder) {
...

answered Aug 6, 2020 at 12:26

Kluk

1337 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Walter Mitty · Accepted Answer · 2020-08-06 13:13:55Z

0

Try removing the parentheses around $i.

Unlike most languages, Powershell does not require parentheses around the actual parameters on a function call. They may be doing harm.

Also, thanks to lieven Keersmaekers, the left brace in the definition should be after the parameter definiton, not before it.

answered Aug 6, 2020 at 13:13

Walter Mitty

19k2 gold badges32 silver badges60 bronze badges

Collectives™ on Stack Overflow

Powershell: For each loop loop with list issues

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related