jQuery ajax "too much recursion"

Question

I have an procedure that runs throught 5 consecutive steps, and in my page, I'm calling an ajax method for each of them.

The idea is to run the first, if all is ok the second, and so on.

My code is:

$("#foo").click(function(){
    $.ajax({
        url: 'ajax.php',
        async: false,
        data: {
            step: 1
        },
        dataType: 'json',
        type: 'GET',
        success: walk_through(data)
    });
});

function walk_through(data)
{
    if(data.status == 'ok')
    {
        if(data.next_step == 'end')
        {
            // All steps completed
        }
        else
        {
            // Current step completed, run next one
            $.ajax({
                url: 'ajax.php',
                async: false,
                data: {
                    step: data.next_step
                },
                dataType: 'json',
                type: 'GET',
                success: walk_through(data)
            });
        }
    }
    else
    {
        alert("Error.");
        console.log(data);
    }
}

Im getting "too much recursion" error, even if my ajax calls are set as syncronous.. why?

Does the code work despite the error, or is it failing? Do you really want the requests to be synchronous? It wouldn't be recursive at all if they were asynchronous. — Pointy
– Pointy, Commented Jun 13, 2011 at 12:41
you obviously do not ever get next_step == 'end' check what is the response — venimus
– venimus, Commented Jun 13, 2011 at 12:44
@Pointy: no, I dont need the requests to be syncronous, but i thought the problem was that — Strae
– Strae, Commented Jun 13, 2011 at 12:57

davin · Accepted Answer · 2011-06-13 12:43:28Z

9

Change

success: walk_through(data)

To

success: walk_through

You want the function walk_through to be the success handler, but you don't want to call the function immediately.

answered Jun 13, 2011 at 12:43

davin

45.6k9 gold badges81 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Guffa Over a year ago

+1 Good spot. This is the actual problem. It will call the method to get the value to put in the success property, so it will never get as far as doing any ajax call at all.

Tomasz Durka Over a year ago

This for sure. By passing walk_through(data) you're executing function and passing result as onSuccess method. You need to pass method itself.

Strae Over a year ago

Thats was the problem! Thanks!

Adam Terlson · Accepted Answer · 2011-06-13 12:42:07Z

2

Your JavaScript is wrong on your AJAX call:

$.ajax({
    url: 'ajax.php',
    async: false,
    data: {
      step: data.next_step
    },
    dataType: 'json',
    type: 'GET',
    success: walk_through //You had walk_through(data), which makes a function call, rather than a reference to a function.
});

answered Jun 13, 2011 at 12:42

Adam Terlson

12.7k4 gold badges46 silver badges63 bronze badges

Comments

Matthew Riches · Accepted Answer · 2011-06-13 12:42:47Z

0

Your walk_through function is calling itself everytime it is succesful.

answered Jun 13, 2011 at 12:42

Matthew Riches

2,28418 silver badges26 bronze badges

1 Comment

Shurdoof Over a year ago

Actually it calls itself even when it's not.

Collectives™ on Stack Overflow

jQuery ajax "too much recursion"

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related