Delete not working and redirecting to the same page - Laravel

Question

I am new to laravel and was facing a problem. I have made a delete function in Controller and added it in the route properly. Then I connected it to a button in the view. When I press the button, it redirects me to the same page without deleting anything.

Here's my function :

 public function delete_user($id){
        $data = User::where('id' , $id);
        $data->delete();
        return route('home');
    }

Here's my route :

Route::get('/delete/user/{id}' , 'UserController@delete_user');

I am adding it in view like this :

 <a href="{{action('UserController@delete_user' , $user->id)}}"><button class="btn btn-info btn-fill pull-right">Delete Profile</button></a>

After redirecting there is a ? infront of the url like abcd.com/delete/1?

When I hover over the button, it shows the correct route(bottom left corner in image), but nothing is happening when I press it :

Any help would be appreciated. Thanks

EDIT : The same function works perfectly fine in another view instance.

Muhammad Rizwan Munawar · Accepted Answer · 2020-09-03 19:17:09Z

1

you need to modify your delete function inside controller like below...

public function delete_user($id){
        $data = User::find($id);
        $data->delete();
        return redirect('/home'); //write name of view where you want to go.
    }

edited Sep 3, 2020 at 19:17

answered Sep 3, 2020 at 19:12

Muhammad Rizwan Munawar

6924 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user8034901 Over a year ago

User::where('id' , $id) will not do much, missing a ->first(). Or simply use User::find($id)

Muhammad Rizwan Munawar Over a year ago

Thanks @kerbh0lz

Hasnat Over a year ago

It does not work, it just redirects to the same link with a ? infornt i.e abcd.com/delete/1? from abcd.com/delete/1

tsommie · Accepted Answer · 2020-09-03 19:22:22Z

1

try this:

public function delete_user($id){
    $data = User::where('id' , $id)->first();
    // or
    // $data = User::find($id);

    $data->delete();

    return route('home');
}

Whenever you use the where clause to retrieve a single resource you have to call first() or get() for a collection.

Try doing it this way:

Controller method

public function delete_user($id){

    $user = User::findOrFail($id);

    $user->delete();

    return route('home');
}

Route

Route::delete('/delete/user/{id}' , 'UserController@delete_user')->name('delete-user');

View

<a class="btn btn-info btn-fill pull-right" href="{{ route('delete-user') }}"
    onclick="event.preventDefault();
         document.getElementById('delete-user').submit();">
    {{ __('Delete user') }}
</a>

<form id="delete-user" action="{{ route('delete-user') }}" method="POST" style="display: none;">
   @csrf
</form>

Also I think <a href="{{action('UserController@delete_user' , $user->id)}}"><button class="btn btn-info btn-fill pull-right">Delete Profile</button></a> should be problematic because you have a button inside a link...its wrong. If you want to use button the the approach I just showed you is better. but really your link should look like:

 <a href="{{ url("/delete/user/{$user->id}")}}">Delete Profile</a>

edited Sep 3, 2020 at 19:22

answered Sep 3, 2020 at 19:11

tsommie

5104 silver badges13 bronze badges

1 Comment

Hasnat Over a year ago

it just redirects to the same link with a ? infornt i.e abcd.com/delete/1? from abcd.com/delete/1

Hasnat · Accepted Answer · 2020-09-03 19:29:14Z

0

After some experimentation it seems that I made a rather careless mistake. I was deleting as a form submit type. I just took the button outside the form and it worked perfectly.

answered Sep 3, 2020 at 19:29

Hasnat

9412 bronze badges

Collectives™ on Stack Overflow

Delete not working and redirecting to the same page - Laravel

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related