Adding a new property to an array of objects. Parallel

Question

I'd like to add a new property to an array of objects. Add-member doesn't work, please assist

$computers = Get-ADComputer -Filter {(name -like "SMZ-*-DB")} | select -First 30
workflow test-test
{
    param([Parameter(mandatory=$true)][string[]]$computers)
    $out = @()
    foreach -parallel -throttlelimit 20 ($computer in $computers)
    {
        sequence
        {
            [bool]$ping = (Test-Connection $computer.name -Quiet -Count 1)
            $computer = $computer | Add-Member -NotePropertyName "Ping" -NotePropertyValue $ping            
            $Workflow:out += $computer
            

        }
    }
    return $out  

}
test-test $computers

js2010 · Accepted Answer · 2020-11-25 15:59:40Z

1

You can do something like this in powershell 7. It looks like the ADComputer objects from Get-ADComputer are read-only, so you can't add members to them.

Get-ADComputer -filter 'name -like "a*"' -resultsetsize 3 |
foreach-object -parallel {
  $computer = $_
  $ping = Test-Connection $computer.name -Quiet -Count 1
  [pscustomobject]@{
    ADComputer = $computer
    Ping = $ping
  }
}

ADComputer                      Ping
----------                      ----
CN=A001,DC=stackoverflow,DC=com True
CN=A002,DC=stackoverflow,DC=com True
CN=A003,DC=stackoverflow,DC=com True

edited Nov 25, 2020 at 15:59

answered Nov 25, 2020 at 15:35

js2010

28.4k6 gold badges82 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Scepticalist · Accepted Answer · 2020-11-25 13:01:03Z

1

If you need ALL the properties of the object or need to use the object later then probably simpler to add it once to the custom object:

    sequence
    {
        [bool]$ping = (Test-Connection $computer.name -Quiet -Count 1)
        $newObj = [pscustomobject]@{ADObject = $computer;Ping = $ping}
        $Workflow:out += $newObj
    }

...but usually you'd just grab the properties you need:

    sequence
    {
        [bool]$ping = (Test-Connection $computer.name -Quiet -Count 1)
        $newObj = [pscustomobject]@{ComputerName = $Computer.Name;Ping = $ping}
        $Workflow:out += $newObj
    }

answered Nov 25, 2020 at 13:01

Scepticalist

3,9331 gold badge16 silver badges31 bronze badges

Comments

A Seyam · Accepted Answer · 2020-11-25 11:42:58Z

0

You are adding to Microsoft.ActiveDirectory.Management.ADComputer Typename not an array.

Try to create a PSCustomObject instead

answered Nov 25, 2020 at 11:42

A Seyam

3472 silver badges13 bronze badges

2 Comments

user2978216 Over a year ago

@a is there a way to copy Microsoft.ActiveDirectory.Management.ADComputer to a custom object?

A Seyam Over a year ago

The full solution has been given by js2010, please mark the answers once you confirm it's working

Collectives™ on Stack Overflow

Adding a new property to an array of objects. Parallel

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related