SwiftUI EditButton() does not work when set editMode in NavigationLink

Question

I have EditNoteHost view which displays NoteView or EditNote depending on editMode environment variable. Aslo Cancel button is displayed in edit mode:


struct EditNoteHost: View {
    @EnvironmentObject var modelData: ModelData
    @Environment(\.editMode) var editMode
    
    @State private var draftNote = Note.default
    
    var body: some View {
        VStack(alignment: .leading, spacing: 20) {
            
            HStack {
                if editMode?.wrappedValue == .active {
                    Button("Cancel") {
                        draftNote = modelData.selectedNote
                        editMode?.animation().wrappedValue = .inactive
                    }
                }
                Spacer()
                EditButton()
            }
            
            if editMode?.wrappedValue == .inactive {
                NoteView(note: modelData.selectedNote)
            } else {
                EditNote(note: $draftNote)
                    .onAppear {
                        draftNote = modelData.selectedNote
                    }
                    .onDisappear {
                        modelData.selectedNote = draftNote
                    }
            }
        }
        .padding()
    }
}

struct EditNoteHost_Previews: PreviewProvider {
    static var previews: some View {
        EditNoteHost()
            .environmentObject(ModelData())
    }
}

This code works fine.

Now I want to use EditNoteHost in NavigationLink and start it in edit mode:

NavigationLink(destination: EditNoteHost().environment(\.editMode, Binding.constant(EditMode.active)).environmentObject(modelData)) {
                    Image(systemName: "plus")
                }

This part of code opens EditNoteHost in edit mode if click +. However, Done and Cancel buttons do nothing when tap.

How can I fix this?

Screenshot

Please provide standalone minimal reproducible example.

Asperi
– Asperi

2021-01-28 12:52:36 +00:00
Commented Jan 28, 2021 at 12:52 — Asperi
– Asperi, Commented Jan 28, 2021 at 12:52

SwiftyJoeyy · Accepted Answer · 2022-06-03 08:32:19Z

2

You are setting editMode using .constant(EditMode.active), it will remain active. So do not set the environment for editMode; instead use:

NavigationLink(destination: EditNoteHost()) {
    Image(systemName: "plus")
}

and in EditNoteHost, use:

.onAppear() {
    editMode?.animation().wrappedValue = .active
}

edited Jun 3, 2022 at 8:32

answered Jan 28, 2021 at 13:47

SwiftyJoeyy

5,2242 gold badges19 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

alexk Over a year ago

EditNoteHost().environment(\.editMode, Binding.constant(EditMode.active) means that editMode environment variable will have active state. This is exactly what I need.EditButton() should change state of environment variable but nothing happens

SwiftyJoeyy Over a year ago

yes .constants means that it's always gonna be .active try to avoid using .constant. I edited my answer, let me know if it solves your problem!

alexk Over a year ago

@ S_dnomseD thank you for answer. Unfortunately this does not solve my problem. This will work fine when I create notes. In this case I need edit mode. However, when I select existing notes I need to use EditNoteHost in inactive mode(

SwiftyJoeyy Over a year ago

In that case you can pass a boolean value to EditNoteHost, and in onAppear use: if editing { editMode?.animation().wrappedValue = .active }else { editMode?.animation().wrappedValue = .inactive }. So when you need it active pass EditNoteHost(editing: true), inactive EditNoteHost(editing: false).

alexk Over a year ago

S_dnomseD this looks like a solution. Thank you!

Collectives™ on Stack Overflow

SwiftUI EditButton() does not work when set editMode in NavigationLink

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related