TypeError: Cannot read property 'id' of undefined in dynamic parameters node js

Question

I am trying to make a dynamic parameters in node js where the link /eshop/edit/1111 will take you to edit a specific product but every time i try to add a product code after the /edit/ i get TypeError: Cannot read property 'id' of undefined

this is my server code

router.get('/edit/:id', async (res, req) =>
{
    let id = req.params.id;
    
    let data = {
        title: `Edit product ${code} | BuckStar`,
        pageTitle: `Edit product ${code}`,
        product: id
    };

    data.res = await results.editProduct(id, req.body.category, req.body.name, req.body.description, req.body.price, req.body.amount, req.body.amount, req.body.location);

    res.render("page/create-edit", data)
});

J Livengood · Accepted Answer · 2021-03-13 03:51:12Z

2

The error here is you have the arguments in the wrong order for your handler. It should be (req, res) => in that order.

Full code being:

router.get('/edit/:id', async (req, res) =>
{
    let id = req.params.id;
    
    let data = {
        title: `Edit product ${code} | BuckStar`,
        pageTitle: `Edit product ${code}`,
        product: id
    };

    data.res = await results.editProduct(id, req.body.category, req.body.name, req.body.description, req.body.price, req.body.amount, req.body.amount, req.body.location);

    res.render("page/create-edit", data)
});

answered Mar 13, 2021 at 3:51

J Livengood

2,7261 gold badge15 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

doj · Accepted Answer · 2021-03-13 05:49:30Z

2

I think the correct code is this as the request should come before response

router.get('/edit/:id', async (req,res ) =>
{

});

answered Mar 13, 2021 at 5:49

doj

1561 silver badge7 bronze badges

1 Comment

Cully Over a year ago

How is this the accepted answer? It's basically a copy of an answer submitted two hours before it.

Andrew Ogaga · Accepted Answer · 2021-03-13 04:14:41Z

1

I believe you exchanged the response and request parameters.

See link below for Express documentation.

http://expressjs.com/en/guide/routing.html

answered Mar 13, 2021 at 4:14

Andrew Ogaga

1065 bronze badges

Collectives™ on Stack Overflow

TypeError: Cannot read property 'id' of undefined in dynamic parameters node js

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related