Merge two rows into single row based on a column using LINQ C#

Question

I have a object list like below. I want to join every two rows into single row based on column B. It is sure that only two rows would be there for every single column B value.

Input

Output

However, I have done it and solution works. but I am looking for more better solution. I am not much happy with my solution.

My solution:

var groupByItems = items.GroupBy(x => x.ColumnB).Select(x => new MappingClass
        {
            ColumnA= x.FirstOrDefault().ColumnA,
            ColumnB= x.FirstOrDefault().ColumnB,
            ColumnC= x.Where(r=> !string.IsNullOrEmpty(r.ColumnC)).Select(r=>r.ColumnC).FirstOrDefault(),
            ColumnD= x.Where(r => !string.IsNullOrEmpty(r.ColumnD)).Select(r => r.ColumnD).FirstOrDefault(),
        }).ToList();

Now groupByItems object returns me two rows as expected.

So what code have you got so far? What bit are you stuck on? — auburg
– auburg, Commented Apr 25, 2021 at 10:38
@auburg Added my solution below to the question. However my solution works, but I am not happy with it and looking for more better solution. I think It could. — Rahul
– Rahul, Commented Apr 25, 2021 at 10:42
SO isn’t really the place for suggesting improvements to working code. Perhaps post at codereview.stackexchange.com. I don’t see much wrong with what you’re doing — auburg
– auburg, Commented Apr 25, 2021 at 10:46

Mahmoud Nasser · Accepted Answer · 2021-04-28 13:40:06Z

1

You can use Key of the Groups generated by GroupBy() Also, there's no need to use .Where() you can simply put your filter as a lambda expression in .FirstOrDefault() for ColumnC & ColumnD

var groupByItems = items.GroupBy(x => new { ColumnA = x.ColumnA, ColumnB = x.ColumnB })
                        .Select(x => new MappingClass
                        {
                            ColumnA = x.Key.ColumnA,
                            ColumnB = x.Key.ColumnB,
                            ColumnC = x.FirstOrDefault(m => !string.IsNullOrEmpty(m.ColumnC)).ColumnC,
                            ColumnD = x.FirstOrDefault(m => !string.IsNullOrEmpty(m.ColumnD)).ColumnD
                        })
                        .ToList();

answered Apr 28, 2021 at 13:40

Mahmoud Nasser

1051 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Merge two rows into single row based on a column using LINQ C#

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related