nested loop will not iterate in random password generator

Question

I have having trouble with my num_char output in my random password generator. I am getting the number of passwords but not the length on each password. Can you solve this?

from random import choice
import string

def create_password():

    num_passwords = int(input('How many passwords would you like?  '))
    num_char = int(input('How long would you like your password to be?  '))
    
    for j in range(num_passwords):
        for k in range(num_char):
            password = ''.join([choice(string.ascii_lowercase + string.ascii_uppercase + string.digits)])
            num_passwords -=1
        print(password)

create_password()

output:

y
t
K
S
7

Did you even try to use a debugger on this?

Scott Hunter
– Scott Hunter

2021-06-10 02:07:24 +00:00
Commented Jun 10, 2021 at 2:07 — Scott Hunter
– Scott Hunter, Commented Jun 10, 2021 at 2:07

Thavas Antonio · Accepted Answer · 2021-06-10 02:07:32Z

2

You might want to use list comprehension

Also, you don't need num_passwords -=1

And this

password = ''.join([choice(string.ascii_lowercase + string.ascii_uppercase + string.digits)])

Will give you something like a per password

from random import choice
import string

def create_password():

    num_passwords = int(input('How many passwords would you like?  '))
    num_char = int(input('How long would you like your password to be?  '))
    
    for j in range(num_passwords):
        pwd = [choice(string.ascii_lowercase + string.ascii_uppercase + string.digits) for k in range(num_char)]
        print(''.join(pwd))
create_password()

output (num_pwd = 5, num_char = 5)

VY1bi
jAvLG
zUxlo
jMBZD
VQHV6

answered Jun 10, 2021 at 2:07

Thavas Antonio

5,8991 gold badge19 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nay · Accepted Answer · 2021-06-10 03:02:18Z

1

this maybe easier to understand for beginer.
but list comprehension is better solution

from random import choice
import string

def create_password():

    num_passwords = int(input('How many passwords would you like?  '))
    num_char = int(input('How long would you like your password to be?  '))
    
    for j in range(num_passwords):
        password = ''
        for k in range(num_char):
            #in your code.you just replace password to last one every time
            password += ''.join([choice(string.ascii_lowercase + string.ascii_uppercase + string.digits)])
            # num_passwords -=1 #no need for this
        print(password)

create_password()

answered Jun 10, 2021 at 3:02

nay

1,7751 gold badge11 silver badges11 bronze badges

Collectives™ on Stack Overflow

nested loop will not iterate in random password generator

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related