what should I use instead of array_unique in php?

Question

I am getting duplicate data in an array and that data is storing in my DB. I am using array_unique to refine the duplicate data but it is not working. Please tell me is there any other way to make data unique and store in DB this way.

if (preg_match($keywords, $links[$i]->href)) {
    if (filter_var($links[$i]->href, FILTER_VALIDATE_URL) !== false) {
        array_push($mainNews, $links[$i]->href);
    }
}
    return (array_unique($mainNews));

Error I am getting:

Undefined array key 1 at C:\xampp\htdocs\pacra-crawlers\modules\crawlers\services\MainNewsRepository.php:46

    for ($i = 0; $i < count($mainNewsLinks); $i++) {
        $mainNews = new MainNews();
        $mainNews->newspaper_id = $this->newspaperId;
        $mainNews->sector_id = $sectorId;
        $mainNews->url = $mainNewsLinks[$i];
        $mainNews->save();
    }
    return ['status' => true];
}

C:\xampp\htdocs\pacra-crawlers\modules\crawlers\services\MainNewsRepository.php:46 Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Undefined array key 1", "C:\xampp\htdocs\pacra-crawlers\modules\crawlers\services\MainNewsRepo sitory.php")

In one part of your code $mainNews is an array, in another it's an object. I don't see where $mainNewsLinks is initialised. It seems likely that you've confused a variable name somewhere. — Tangentially Perpendicular
– Tangentially Perpendicular, Commented Jun 16, 2021 at 11:13
$mainnewsLinks is initialized in repo: public function store(array $mainNewsLinks, int $sectorId): array — Umair Basit
– Umair Basit, Commented Jun 16, 2021 at 11:15

ggordon · Accepted Answer · 2021-06-16 16:00:36Z

array_unique is working however although it is removing duplicates it is maintaining the same keys i.e.

If you had the following items in an array with

position/key value
0         a
1         a
2         b

array_unique would return

position/key value
0         a
2         b

which is why you are getting the Undefined array key when looping through the array based on the incrementing index $i.

Based on your sample you could use a foreach loop since you are only interested in the value eg

   foreach($mainNewsLinks as $mainNewsLink) {
        $mainNews = new MainNews();
        $mainNews->newspaper_id = $this->newspaperId;
        $mainNews->sector_id = $sectorId;
        $mainNews->url = $mainNewsLink;
        $mainNews->save();
    }

If you would like to continue indexing or iterating through each element based on an index, you could use array_values in your return eg


return array_values(array_unique($mainNews));

from your function to reset the array keys to incrementing indexes

Collectives™ on Stack Overflow

what should I use instead of array_unique in php?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related