Why is this PHP recursion function not working

Question

I wrote a simple php function to walk over a multidimensional array and print its content in a preformatted way. But the function doesn't go deep and only adds first-level leaf nodes to the text.

Can anyone please help to figure out the problem and the solution?

function LOP($arrayItself, $txt){
    foreach($arrayItself as $fieldName=>$fieldValue){       
            if(is_array($fieldValue)){
                    LOP($fieldValue, $txt);
            }
            else {
                    $txt .= "<$fieldName>  $fieldValue  </$fieldName>";
            }
    }
    return $txt;

}

Going out on a limb: since it appears you're trying to build an XML document here, I would recommend generating such a document using a proper XML building library instead of trying to stack up the elements yourself. — esqew
– esqew, Commented Aug 29, 2021 at 15:18

esqew · Accepted Answer · 2021-08-29 15:16:35Z

3

In your if(is_array($fieldValue)) block, you need to capture the return value of your recursive call to LOP():

function LOP($arrayItself, $txt){
    foreach($arrayItself as $fieldName=>$fieldValue){       
            if(is_array($fieldValue)){
                    $txt = LOP($fieldValue, $txt);
            }
            else {
                    $txt .= "<$fieldName>  $fieldValue  </$fieldName>";
            }
    }
    return $txt;
}

answered Aug 29, 2021 at 15:16

esqew

44.9k28 gold badges139 silver badges179 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why is this PHP recursion function not working

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related