Unable to initialize @StateObject ViewModel in SwiftUI

Question

I am trying to inject the managedObjectContext in ViewModel and for some weird reason it is throwing a weird error.

struct ContentView: View {
   
    @Environment(\.managedObjectContext) var viewContext
    @StateObject var addBudgetVM: AddBudgetViewModel
    
    init() {
        // THIS LINE CAUSES ISSUES 
        addBudgetVM = AddBudgetViewModel(context: viewContext)
    }
    
    var body: some View {
       // some code here
    }
    
}

Cannot assign to property: 'addBudgetVM' is a get-only property

Here is the implementation of AddBudgetViewModel

import Foundation
import CoreData

class AddBudgetViewModel: ObservableObject {
    
    @Published var name: String = ""
    var context: NSManagedObjectContext
    
    init(context: NSManagedObjectContext) {
        self.context = context
    }
    
    func save() {
        
    }
    
}

You could make the context optional on your view model and set it on onAppear — jnpdx
– jnpdx, Commented Nov 7, 2021 at 3:22
I agree with @JoakimDanielson. You should inject the view model from the superview — Paulw11
– Paulw11, Commented Nov 7, 2021 at 9:48

Paulw11 · Accepted Answer · 2021-11-08 04:44:43Z

I find the best approach is to inject the view model from the superview. This nicely separates the view, which consumes the view model, from the creation of the view model. It improves testability as it makes it easy to inject a mock view model.

Something like:


struct ParentView: View {
      @Environment(\.managedObjectContext) var viewContext

      var body: some View {
          //...
          AddBudgetView(viewModel: AddBudgetViewModel(context: viewContext))
          //...
      }
}


struct AddBudgetView: View {

      viewModel: AddBudgetViewModel 

      var body: some View {
          // ...
      }
}

class AddBudgetViewModel: ObservableObject {

    private (set) var context: NSManagedObjectContext

    init(context: NSManagedObjectContext) {
    
        self.context = context
    }

   func save() {
    
   }
}

I probably wouldn't even have Core Data code in the view model. I would put all of that in a main model and pass the main model instance to the view model initialiser instead of the managed object context. The view model can then call methods on the main model to create and save items. This way your view model is isolated from the storage implementation detail and you could make changes to your store, such as replacing Core Data, without having to touch view models all over the place.

Collectives™ on Stack Overflow

Unable to initialize @StateObject ViewModel in SwiftUI

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related