How should I refactor this duplicate code?

Question

So I have bot which scrapes page and I want to refactor bot which pseudocode looks like this:

bot.py:

class Bot:
    def __init__(login, password, brand, ...):
        ...
    def log_in():
        ...
    def some_methods_to_scrap():
        ...

and in main.py I have two objects of the same class and I use the same methods on them. They are almost the same besides the parameter 'brand'. In those two cases everything what bot does is the same but for different brands:

main.py

bot1=Bot(login, password, brand=A, ...)
bot1.log_in()
bot1.some_methods_to_scrap()

bot2=Bot(login, password, brand=B, ...)
bot2.log_in()
bot2.some_methods_to_scrap()

Is there any way I can remove the duplicate code in main.py?

def scrape(brand): bot = Bot(login, password, brand=brand, ...); bot.log_in(); ...…? — deceze
– deceze ♦, Commented Nov 10, 2021 at 10:32
removing the unrelated tags – the fact that this is about a bot doesn't relate to the question. (also, fixed your classes indentation – Python is sensitive to that) — Marcus Müller
– Marcus Müller, Commented Nov 10, 2021 at 10:33

Marcus Müller · Accepted Answer · 2021-11-10 10:32:24Z

3

The usual pattern here is simply the for loop:

brands = [A, B]
bots = [Bot(login, password, brand=thisbrand, …) for thisbrand in brands]

for bot in bots:
    bot.log_in()
    bot.some_method_to_scrap()

answered Nov 10, 2021 at 10:32

Marcus Müller

36.9k4 gold badges59 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sefan · Accepted Answer · 2021-11-10 10:49:07Z

0

This can be solved in one loop by looping through the brands:

bots = []
for brand in ['A','B']:
    bots.append(Bot(login, password, brand=brand, ...))
    bots[-1].log_in()
    bots[-1].some_methods_to_scrap()

answered Nov 10, 2021 at 10:49

Sefan

7091 gold badge8 silver badges23 bronze badges

Collectives™ on Stack Overflow

How should I refactor this duplicate code?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related