How can I refactor this python script better?

Question

I am expected to ensure the code is written without unnecessary lines of code. Is there a way to refactor this and get the same output?

def format_name(first_name, last_name):
    if len(first_name) > 0 and len(last_name) > 0:
        return("Name: " + last_name + ", " + first_name)
    elif len(first_name) > 0 or len(last_name) > 0:
        return("Name: " + first_name + last_name)
    else:
        empty_string = ""
        return empty_string
    return string 


print(format_name("Ernest", "Hemingway"))
# Should return the string "Name: Hemingway, Ernest"

print(format_name("", "Madonna"))
# Should return the string "Name: Madonna"

print(format_name("Voltaire", ""))
# Should return the string "Name: Voltaire"

print(format_name("", ""))
# Should return an empty string

JonSG · Accepted Answer · 2022-01-06 13:55:10Z

1

Without getting "too golfie", this should do the trick:

def format_name(first_name, last_name):
    name = f"{first_name}, {last_name}".strip(", ")
    return f"Name: {name}" if name else ""

answered Jan 6, 2022 at 13:55

JonSG

13.6k2 gold badges32 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Danyal Imran · Accepted Answer · 2022-01-06 13:50:11Z

0

The refactored method tries to allocate the logic of the function in a single if condition.

def format_name(first_name, last_name):
    result = ''
    sep = ', ' if first_name and last_name else ' '
    
    if first_name or last_name:
        result = last_name + sep + first_name
        result = 'Name: ' + result.strip()
        
    return result
        
print(format_name("Ernest", "Hemingway")) # "Name: Hemingway, Ernest"
print(format_name("", "Madonna")) # "Name: Madonna"
print(format_name("Voltaire", "")) # "Name: Voltaire"
print(format_name("", "")) # `empty_string`

answered Jan 6, 2022 at 13:50

Danyal Imran

2,60515 silver badges21 bronze badges

Comments

Wups · Accepted Answer · 2022-01-06 13:56:12Z

0

Use str.join and filter to build the name string:

def format_name(first_name, last_name):
    full_name = ", ".join(filter(None, (last_name, first_name)))
    if full_name:
        full_name = "Name: " + full_name
    return full_name

answered Jan 6, 2022 at 13:56

Wups

2,5791 gold badge8 silver badges17 bronze badges

Collectives™ on Stack Overflow

How can I refactor this python script better?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related