Spring not injecting @value annotation in property

Question

I have the following class:

@Component
public class Scheduler {

    @Value("${build.version}")
    private String buildVersion;

    public void test() {
         System.out.println(this.buildVersion);
    }

}

I am calling the method test() from a controller:

@RestController
public class ApiController {

    @GetMapping("/status")
    public StatusResponse status() {
        Scheduler scheduler = new Scheduler();
        scheduler.update();
    }

However spring is not injecting the build.version value even though the class has a @Component annotation.

I am using the same property in a controller and it works fine.

What am I doing wrong?

Everything is correct in the definition. I also tried it out just in case and it works. I used the .properties file. You need to post more code in order to help you more — Tsvetoslav Tsvetkov
– Tsvetoslav Tsvetkov, Commented Jun 22, 2022 at 14:42
How is Scheduler used, and where is #test() being called? — sp00m
– sp00m, Commented Jun 22, 2022 at 14:43
You must @Autowired Scheduler, not create an instance with new, as Spring takes cares of the class managing — Tsvetoslav Tsvetkov
– Tsvetoslav Tsvetkov, Commented Jun 22, 2022 at 14:50

Tsvetoslav Tsvetkov · Accepted Answer · 2022-06-22 14:56:43Z

1

Try out this way, as you create instance with new instead of rely on Spring object managing(Inversion of control)

@RestController
public class ApiController {


   private Scheduler scheduler;

   @Autowired
   public ApiController(Scheduler scheduler) {
      this.scheduler = scheduler 
   }

   @GetMapping("/status")
   public StatusResponse status() {
      scheduler.update();
  }
}

answered Jun 22, 2022 at 14:56

Tsvetoslav Tsvetkov

1,2361 gold badge13 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

trust_nickol · Accepted Answer · 2022-06-24 07:38:37Z

1

If you are using application.yml to provide value to these properties then use @ConfigurationProperties on top of the class. You do not need to give @Value on every property value, for example:

@Component
@Data
@ConfigurationProperties(prefix = "build")
public class SchedulerProperties {

    private String buildVersion;

}

In application.yml define as below

build:
  buildVersion: "XYZ"

Then you can just call version from the properties class

@Component
public class Scheduler {

   @Autowired
   private SchedulerProperties schedulerProperties;

    public void test() {
         System.out.println(schedulerProperties.getBuildVersion());
    }

}

edited Jun 24, 2022 at 7:38

trust_nickol

2,15711 silver badges25 bronze badges

answered Jun 22, 2022 at 14:40

Bhanu

2295 silver badges23 bronze badges

1 Comment

Mathias Hillmann Over a year ago

I am not using any application.yml, just spring's magic.

Collectives™ on Stack Overflow

Spring not injecting @value annotation in property

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related