How to pass data between views and forms using form_valid

Question

I have a simple UserRegistration view:

class UserRegistration(generic.CreateView):
    form_class = RegisterForm
    template_name = 'registration/registration.html'
    success_url = reverse_lazy('home')

    def form_valid(self, form):
        user = form.save()
        login(self.request, user, backend='django.contrib.auth.backends.ModelBackend')
        return redirect(self.success_url)

Which logs the User in after they register. I wanted to send an email confirmation letting the User know they successfully signed up. So I added a method to my RegisterForm:

class RegisterForm(UserCreationForm):
    email = forms.EmailField()
    first_name = forms.CharField(max_length=100)
    last_name = forms.CharField(max_length=100)

    class Meta:
        model = User
        fields = ('username', 'first_name', 'last_name', 'email', 'password1', 'password2')

    def registration_email(request):
        send_mail(
            'Welcome aboard!',
            'Thanks for signing up...',
            NOTIFICATION_EMAIL,
            ['[email protected]'],
            fail_silently=True
        )

Then I call it in my view with form.registration_email().

Now, this works but it's hardcoded. I want the recipient email to be the new User's email they just entered. That info should be available in the view, but how do I pass that to my form? I just can't figure out how to pass data from my views to my form methods, so that I can then call those methods in my view if form is valid.

Should I be doing it like this? Or should I be doing all this in form_valid instead? I also plan on using Celery in the future, so is there a preferred way with regards to that as well?

Maxim Danilov · Accepted Answer · 2022-07-22 20:38:55Z

1

Where should to be send_email method depends on your logic in project.

In your case:

class RegisterForm(UserCreationForm):

    ...

    def registration_email(self, request):
        # it should be only after from.is_valid()
        # to protect us:
        if self.is_valid():
            send_mail(
                'Welcome aboard!',
                'Thanks for signing up...',
                NOTIFICATION_EMAIL,
                [self.cleaned_data['email']],
                fail_silently=True
            )

edited Jul 22, 2022 at 20:38

answered Jul 22, 2022 at 20:25

Maxim Danilov

3,3701 gold badge6 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Yehuda Over a year ago

form is not defined. Should it be self? Also don't I already have a form valid in my view that calls registration_email? So the only way send_mail is being called is if the form is valid.

Maxim Danilov Over a year ago

yes, self. if you don't have any form_valid(), how you save the form without validation?

Yehuda Over a year ago

I assumed that def form_valid would only run if the form was valid. If not then what is it doing?

Maxim Danilov Over a year ago

if form is not valid createview send to user a response with rendered form with errors messages.

Collectives™ on Stack Overflow

How to pass data between views and forms using form_valid

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related